Create ES index templates instead of indices #1627
Conversation
pavolloffay
requested review from
black-adder,
jpkrohling,
objectiser,
tiffon,
vprithvi and
yurishkuro
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1627 +/- ##
=========================================
Coverage ? 98.51%
=========================================
Files ? 193
Lines ? 9274
Branches ? 0
=========================================
Hits ? 9136
Misses ? 110
Partials ? 28
Continue to review full report at Codecov.
|
|
Please do not merge yet! |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
|
cc @jaegertracing/elasticsearch this PR changes behavior if the writer. Now jaeger will not be creating indices, but instead it will create index template at startup. There will be also a flag to disable template creation if it was previously manually installed by a user - needed if jaeger does not have manage permissions on the cluster see #1691 (comment). Please comment if you have any concerns. |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
force-pushed
the
es-templates
branch
from
f78242e
to
308462d
Compare
| @@ -214,6 +216,10 @@ func addFlags(flagSet *flag.FlagSet, nsConfig *namespaceConfig) { | |||
| "(experimental) Use read and write aliases for indices. Use this option with Elasticsearch rollover "+ | |||
| "API. It requires an external component to create aliases before startup and then performing its management. "+ | |||
| "Note that "+nsConfig.namespace+suffixMaxSpanAge+" is not taken into the account and has to be substituted by external component managing read alias.") | |||
| flagSet.Bool( | |||
There was a problem hiding this comment.
@yardbirdsax I have added boolean flag --es.create-index-templates which creates templates at startup when enabled. By default it is enabled.
There was a problem hiding this comment.
That's awesome @pavolloffay , thanks!
|
I will merge this by Friday. If you have any concerns please comment by then. |
|
is it in release 1.14? |
|
Based on the changelog yes https://github.com/jaegertracing/jaeger/blob/master/CHANGELOG.md#1140-2019-09-02 |
Resolves #374
Resolves #622
Instead of creating indices with mapping the collector at start time creates index template. ES uses this index template when a data is inserted to ES.
TODO