Allow Cassandra schema builder to use credentials #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the Cassandra schema builder job only works on open Cassandra installations. This PR fixes this by modifying the script so that two environmental variables, CASSANDRA_USER and CASSANDRA_PASSWORD, could be passed in to supply these credentials. Signed-off-by: E.G. Hornbostel <eg.hornbostel@pricespider.com>
EGHornbostel
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon,
vprithvi and
yurishkuro
as code owners
yurishkuro
approved these changes
Jun 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #1635 +/- ##
==========================================
+ Coverage 98.72% 98.74% +0.02%
==========================================
Files 191 191
Lines 9182 9182
==========================================
+ Hits 9065 9067 +2
+ Misses 91 89 -2
Partials 26 26
Continue to review full report at Codecov.
|
|
build failed |
yurishkuro
reviewed
Jun 26, 2019
| @@ -31,4 +33,9 @@ done | |||
|
|
|||
| echo "Generating the schema for the keyspace ${KEYSPACE} and datacenter ${DATACENTER}" | |||
|
|
|||
| MODE="${MODE}" DATACENTER="${DATACENTER}" KEYSPACE="${KEYSPACE}" /cassandra-schema/create.sh "${TEMPLATE}" | ${CQLSH} ${CQLSH_SSL} ${CQLSH_HOST} | |||
|
|
|||
| if [ -z "$PASSWORD" ] then | |||
There was a problem hiding this comment.
missing semicolon before then
Signed-off-by: E.G. Hornbostel <eg.hornbostel@pricespider.com>
|
thanks @PS-EGHornbostel |
MiLk
added a commit
to MiLk/jaeger
that referenced
this pull request
Jul 5, 2019
This follows jaegertracing#1635 in order to solve jaegertracing/jaeger-operator#469
MiLk
added a commit
to MiLk/jaeger
that referenced
this pull request
Jul 5, 2019
This follows jaegertracing#1635 in order to solve jaegertracing/jaeger-operator#469 Signed-off-by: Emilien Kenler <emilien@cryptact.com>
yurishkuro
pushed a commit
that referenced
this pull request
Jul 5, 2019
…#1655) This follows #1635 in order to solve jaegertracing/jaeger-operator#469 Signed-off-by: Emilien Kenler <emilien@cryptact.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Cassandra schema builder job only works on open Cassandra installations. This PR fixes this by modifying the script so that two environmental variables, CASSANDRA_USER and CASSANDRA_PASSWORD, could be passed in to supply these credentials.
Signed-off-by: E.G. Hornbostel eg.hornbostel@pricespider.com
Which problem is this PR solving?
Short description of the changes