Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CA certificates to agent image #1764

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

yurishkuro
Copy link
Member

Resolves #1760, similar to #598.

@jpkrohling @pavolloffay please review

Signed-off-by: Yuri Shkuro <ys@uber.com>
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jpkrohling
Copy link
Contributor

jpkrohling commented Aug 27, 2019

For the record, the image is just marginally bigger:

Before this change:

jaegertracing/jaeger-agent ... 26.9MB

After this change:

jaegertracing/jaeger-agent ... 27.1MB

@pavolloffay pavolloffay merged commit 3245d3f into jaegertracing:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger Agent container should trust certificates from public CAs by default
3 participants