Set an empty value when a default env var value is missing #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
requested review from
black-adder,
objectiser,
pavolloffay,
tiffon and
vprithvi
as code owners
|
@jpkrohling If there is no default specified, and the env var is not set, then I would expect the behaviour to be no tag created. If the user wants to still create the tag if no env var, then that is when they would specify just the colon? |
That's a good argument. |
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Codecov Report
@@ Coverage Diff @@
## master #1777 +/- ##
==========================================
+ Coverage 98.27% 98.27% +<.01%
==========================================
Files 195 195
Lines 9540 9546 +6
==========================================
+ Hits 9375 9381 +6
Misses 131 131
Partials 34 34
Continue to review full report at Codecov.
|
objectiser
approved these changes
Sep 6, 2019
bookmoons
pushed a commit
to bookmoons/jaeger
that referenced
this pull request
Sep 10, 2019
…tags pair (jaegertracing#1777) * Set an empty value when a default env var value is missing Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Skip value when default isn't specified Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de
Which problem is this PR solving?