Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect section from Elasticsearch readme #1839

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Remove incorrect section from Elasticsearch readme #1839

merged 1 commit into from
Oct 9, 2019

Conversation

backjo
Copy link
Contributor

@backjo backjo commented Oct 7, 2019

Signed-off-by: Jonah Back jonah@jonahback.com

Which problem is this PR solving?

  • Removes incorrect documentation

Short description of the changes

@backjo
Remove incorrect limitation in README.
2b38340 
Signed-off-by: Jonah Back <jonah@jonahback.com>
@backjo
Copy link
Contributor Author

backjo commented Oct 7, 2019

This change is Reviewable

@backjo backjo closed this Oct 7, 2019
@backjo backjo reopened this Oct 7, 2019
@codecov
Copy link

codecov bot commented Oct 7, 2019 •
edited
Loading

Codecov Report

Merging #1839 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1839   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         195      195           
  Lines        9603     9603           
=======================================
  Hits         9432     9432           
  Misses        134      134           
  Partials       37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc0adb...2b38340. Read the comment docs.

@yurishkuro
Copy link
Member

@pavolloffay can you review?

pavolloffay
pavolloffay approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole readme seems to be outdated.

@pavolloffay pavolloffay merged commit 632379e into jaegertracing:master Oct 9, 2019
@pavolloffay pavolloffay changed the title Remove incorrect elasticsearch limitation in README Remove incorrect section from Elasticsearch readme Oct 9, 2019
@backjo backjo deleted the removeDatedReadme branch October 10, 2019 05:47
backjo added a commit to backjo/jaeger that referenced this pull request Dec 19, 2019
@backjo
Remove incorrect section from Elasticsearch readme (jaegertracing#1839)
30c6d65 
Signed-off-by: Jonah Back <jonah@jonahback.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

@black-adder black-adder Awaiting requested review from black-adder

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@objectiser objectiser Awaiting requested review from objectiser

@tiffon tiffon Awaiting requested review from tiffon

@vprithvi vprithvi Awaiting requested review from vprithvi

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@backjo @yurishkuro @pavolloffay