Decouple storage dependencies and bump Go to 1.13.x #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
requested review from
black-adder,
jpkrohling,
objectiser,
pavolloffay,
tiffon and
vprithvi
as code owners
objectiser
approved these changes
Oct 29, 2019
added 2 commits
October 29, 2019 11:20
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
force-pushed
the
decouple-storage-deps
branch
from
1674ae5
to
b576dd7
Compare
yurishkuro
changed the title
added 3 commits
October 29, 2019 11:29
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #1886 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 197 197
Lines 9645 9645
=======================================
Hits 9495 9495
Misses 114 114
Partials 36 36Continue to review full report at Codecov.
|
|
Data race in in-memory storage uncovered, fixing it a well. |
backjo
pushed a commit
to backjo/jaeger
that referenced
this pull request
Dec 19, 2019
* Decouple storage dependencies Signed-off-by: Yuri Shkuro <ys@uber.com> * Bump Go version to 1.13.x Signed-off-by: Yuri Shkuro <ys@uber.com> * Fix quotes Signed-off-by: Yuri Shkuro <ys@uber.com> * Force go modules off Signed-off-by: Yuri Shkuro <ys@uber.com> * Fix data race Signed-off-by: Yuri Shkuro <ys@uber.com> Signed-off-by: Jonah Back <jonah@jonahback.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this little dependency pulls all storage implementations into custom builds, not worth it.
The Go bump is needed as staticcheck is failing on 1.12