Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for dynamic queue sizes #1985

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Added support for dynamic queue sizes #1985

merged 1 commit into from
Jan 23, 2020

Commits on Jan 23, 2020

  1. Added support for dynamic queue sizes.

    * Introduces the new flags: collector.dyn-queue-size-warmup and collector.dyn-queue-size-memory.
    * When the warm-up flag is set, the span processor starts a new background process to recalculate the queue capacity at regular intervals.
    * The span processor now keeps track of the number of spans it has seen, as well as the total bytes it processed. That information allows to derive the average spans size that the collector has processed. Along with the memory to allocate, we can come up with the ideal queue size.
    * New metrics: jaeger_collector_queue_capacity and jaeger_collector_spans_bytes.
    
    This commit shouldn't cause performance degradation for instances not using the new options, except for a small memory overhead due to the new span tracker (quantity/size) and the new metrics.
    
    Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
    jpkrohling committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    012056c View commit details
    Browse the repository at this point in the history