Removed CGO_ENABLED from Makefile

[jpkrohling]

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Short description of the changes

• Extracted the CGO_ENABLED changes from Added support for dynamic queue sizes #1985

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@617f0f3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2003   +/-   ##
=========================================
  Coverage          ?   96.95%           
=========================================
  Files             ?      205           
  Lines             ?    10119           
  Branches          ?        0           
=========================================
  Hits              ?     9811           
  Misses            ?      269           
  Partials          ?       39

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 617f0f3...08dd3b1. Read the comment docs.

[jpkrohling]

So far, I couldn't get a clean build of this. I'll try a few more times, but I'm starting to wonder if this isn't required after all...

[jpkrohling]

Looks like we can't remove it without changing the base docker image. The container image generated by this PR yields this:

$ docker run quay.io/jpkroehling/jaeger-all-in-one:latest
{"msg":"exec the container process: No such file or directory","level":"error","time":"2020-01-10T15:47:47.000583497Z"}

Changing the base image to registry.access.redhat.com/ubi8/ubi-minimal:latest made it work:

$ docker run quay.io/jpkroehling/jaeger-all-in-one:latest
2020/01/10 15:53:07 maxprocs: Leaving GOMAXPROCS=8: CPU quota undefined
{"level":"info","ts":1578671587.660807,"caller":"flags/service.go:115","msg":"Mounting metrics handler on admin server","route":"/metrics"}
{"level":"info","ts":1578671587.6615405,"caller":"flags/admin.go:108","msg":"Mounting health check on admin server","route":"/"}
{"level":"info","ts":1578671587.6616032,"caller":"flags/admin.go:114","msg":"Starting admin HTTP server","http-port":14269}
{"level":"info","ts":1578671587.6616244,"caller":"flags/admin.go:100","msg":"Admin server started","http-port":14269,"health-status":"unavailable"}
{"level":"info","ts":1578671587.670309,"caller":"memory/factory.go:56","msg":"Memory storage initialized","configuration":{"MaxTraces":0}}
{"level":"info","ts":1578671587.684576,"caller":"all-in-one/main.go:243","msg":"Starting jaeger-collector TChannel server","port":14267}
{"level":"warn","ts":1578671587.68461,"caller":"all-in-one/main.go:244","msg":"TChannel has been deprecated and will be removed in a future release"}
{"level":"info","ts":1578671587.6846702,"caller":"grpcserver/grpc_server.go:64","msg":"Starting jaeger-collector gRPC server","grpc-port":"14250"}
{"level":"info","ts":1578671587.6848485,"caller":"all-in-one/main.go:273","msg":"Starting jaeger-collector HTTP server","http-host-port":":14268"}
{"level":"info","ts":1578671587.68487,"caller":"grpc/builder.go:65","msg":"Agent requested insecure grpc connection to collector(s)"}
{"level":"info","ts":1578671587.686604,"caller":"all-in-one/main.go:203","msg":"Starting agent"}
{"level":"info","ts":1578671587.686908,"caller":"querysvc/query_service.go:133","msg":"Archive storage not created","reason":"archive storage not supported"}
{"level":"info","ts":1578671587.6869707,"caller":"all-in-one/main.go:355","msg":"Archive storage not initialized"}
{"level":"info","ts":1578671587.687005,"caller":"app/agent.go:70","msg":"Starting jaeger-agent HTTP server","http-port":5778}
{"level":"info","ts":1578671587.6882775,"caller":"app/server.go:112","msg":"Starting HTTP server","port":16686}
{"level":"info","ts":1578671587.688263,"caller":"healthcheck/handler.go:128","msg":"Health Check state change","status":"ready"}
{"level":"info","ts":1578671587.6883724,"caller":"app/server.go:135","msg":"Starting CMUX server","port":16686}
{"level":"info","ts":1578671587.6883926,"caller":"app/server.go:125","msg":"Starting GRPC server","port":16686}
^C{"level":"info","ts":1578671588.889131,"caller":"flags/service.go:145","msg":"Shutting down"}
{"level":"info","ts":1578671588.8892682,"caller":"healthcheck/handler.go:128","msg":"Health Check state change","status":"unavailable"}
{"level":"info","ts":1578671588.8901768,"caller":"flags/service.go:153","msg":"Shutdown complete"}

I updated this PR to use registry.access.redhat.com/ubi8/ubi-minimal:latest instead, just to check that this works. We can then either discard this PR, or decide to use a different base image (perhaps even the Red Hat one, which is publicly available)

[yurishkuro]

The need for alternative base image suggests that removing CGO_ENABLED=0 is not as innocuous is it appears, so I would suggest dropping this PR.

[jpkrohling]

+1