Remove tchannel between agent and collector #2115
Conversation
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #2115 +/- ##
==========================================
- Coverage 96.12% 96.12% -0.01%
==========================================
Files 217 217
Lines 10541 10538 -3
==========================================
- Hits 10133 10130 -3
Misses 353 353
Partials 55 55 Continue to review full report at Codecov.
|
| @@ -55,11 +54,9 @@ func main() { | |||
| Namespace(metrics.NSOptions{Name: "agent"}) | |||
|
|
|||
| rOpts := new(reporter.Options).InitFromViper(v, logger) | |||
| tchanBuilder := tchannel.NewBuilder().InitFromViper(v, logger) | |||
| grpcBuilder := grpc.NewConnBuilder().InitFromViper(v) | |||
| builders := map[reporter.Type]app.CollectorProxyBuilder{ | |||
There was a problem hiding this comment.
Do we need a map here now? We have just one exporter
There was a problem hiding this comment.
It's needed for extensibility. E.g. at uber they will add custom reporters.
| @@ -36,7 +36,6 @@ import ( | |||
| ss "github.com/jaegertracing/jaeger/plugin/sampling/strategystore" | |||
| "github.com/jaegertracing/jaeger/plugin/storage" | |||
| "github.com/jaegertracing/jaeger/ports" | |||
| tCollector "github.com/jaegertracing/jaeger/tchannel/collector/app" | |||
There was a problem hiding this comment.
Is this issue also dealing with removing the tchannel endpoint from the collector? End user applications will not be able to send spans directly to the collector? This is a breaking change and should be documented
There was a problem hiding this comment.
End applications are not using this port. This is used only by the agent.
CHANGELOG.md
Outdated
| @@ -6,6 +6,24 @@ Changes by Version | |||
|
|
|||
| ### Backend Changes | |||
There was a problem hiding this comment.
Maybe it should go in breaking changes
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Resolves #2105
Signed-off-by: Pavol Loffay ploffay@redhat.com