Create Jaeger OTEL agent component #2216
Conversation
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
|
@rubenvp8510 or/and @objectiser could you please review? |
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #2216 +/- ##
==========================================
- Coverage 96.17% 96.16% -0.01%
==========================================
Files 219 219
Lines 10632 10632
==========================================
- Hits 10225 10224 -1
Misses 352 352
- Partials 55 56 +1
Continue to review full report at Codecov.
|
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
| } | ||
| otelCfg = c | ||
| } | ||
| err := defaults.MergeConfigs(cfg, otelCfg) |
There was a problem hiding this comment.
Shouldn't the merge be inside the above if block? Merge only required if OTel config file provided?
There was a problem hiding this comment.
The function correctly handles merge if the second parameter is nil
| cmd := svc.Command() | ||
| jconfig.AddFlags(v, | ||
| cmd, | ||
| jflags.AddConfigFileFlag, |
There was a problem hiding this comment.
In the collector main it also has collectorApp.AddFlags - should the equivalent agentApp.AddFlags be here?
There was a problem hiding this comment.
Not needed if there is no flag we want to consume.
This issue #2182 will do some hygiene on flags. We can either expose all or just expose what is used by the new component. For less confusion I think we should expose only what is being used.
| pipelines: | ||
| traces: | ||
| exporters: [jaeger] | ||
| # TODO remove after https://github.com/open-telemetry/opentelemetry-collector/pull/910 |
There was a problem hiding this comment.
Seems to have been merged.
There was a problem hiding this comment.
I will update this in a follow-up PR as it requires changes in files not related to this PR.
Resolves #2204
This PR adds a new component - Jaeger Agent based on OpenTelemetry.
Notable changes:
--reporter.grpc.host-portis used to configure Jaeger exporter endpoint and also fetch endpoint for sampling strategies in Jaeger receiver.