Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go-plugin to 1.3 #2261

Merged
merged 1 commit into from
May 28, 2020
Merged

Conversation

yurishkuro
Copy link
Member

Related to #2071

Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro yurishkuro requested a review from a team as a code owner May 27, 2020 21:59
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #2261 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2261      +/-   ##
==========================================
- Coverage   96.15%   96.13%   -0.02%     
==========================================
  Files         219      219              
  Lines       10658    10658              
==========================================
- Hits        10248    10246       -2     
- Misses        352      354       +2     
  Partials       58       58              
Impacted Files Coverage Δ
cmd/query/app/server.go 91.89% <0.00%> (-2.71%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.79% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123bc01...8086bc4. Read the comment docs.

@yurishkuro
Copy link
Member Author

cc @pavolloffay

@pavolloffay
Copy link
Member

Do the existing plugins have to be rebuild after the plugin version bump?

@yurishkuro
Copy link
Member Author

Do the existing plugins have to be rebuild after the plugin version bump?

I hope not, because there should be no wire API changes in the upgrade.

@yurishkuro yurishkuro merged commit 06c8f7c into jaegertracing:master May 28, 2020
@yurishkuro yurishkuro deleted the bump-grpc-plugin branch May 28, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants