Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace anonymizer prorotype #2328

Merged
merged 3 commits into from
Jul 4, 2020

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jul 4, 2020

The anonymizer is used to obfuscate production traces before sharing them with academics.

Moving code from Uber's internal repo. The binary does not do anything yet, it needs to be wired with a source of spans, e.g. the Uber version tails production Kafka stream until it sees N spans.

@yurishkuro yurishkuro requested a review from a team as a code owner July 4, 2020 19:02
@yurishkuro yurishkuro requested a review from vprithvi July 4, 2020 19:02
Yuri Shkuro added 3 commits July 4, 2020 16:13
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #2328 into master will decrease coverage by 0.55%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2328      +/-   ##
==========================================
- Coverage   96.21%   95.65%   -0.56%     
==========================================
  Files         203      205       +2     
  Lines       10291    10529     +238     
==========================================
+ Hits         9901    10072     +171     
- Misses        334      391      +57     
- Partials       56       66      +10     
Impacted Files Coverage Δ
plugin/storage/integration/trace_compare.go 36.58% <ø> (ø)
plugin/storage/integration/integration.go 80.38% <92.85%> (ø)
plugin/storage/es/factory.go 100.00% <100.00%> (ø)
plugin/storage/badger/spanstore/reader.go 96.15% <0.00%> (-0.65%) ⬇️
cmd/query/app/static_handler.go 85.83% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b6e96...01fc385. Read the comment docs.

@yurishkuro yurishkuro merged commit 5001225 into jaegertracing:master Jul 4, 2020
@yurishkuro yurishkuro deleted the anonymizer branch July 4, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant