Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI placeholder message #2487

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

yurishkuro
Copy link
Member

Fixes #2486.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner September 17, 2020 14:27
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #2487 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2487   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files         208      208           
  Lines       10759    10759           
=======================================
+ Hits        10277    10278    +1     
+ Misses        406      405    -1     
  Partials       76       76           
Impacted Files Coverage Δ
plugin/storage/integration/integration.go 81.39% <0.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd57f3...c5ef1fa. Read the comment docs.

@yurishkuro yurishkuro merged commit ea2f2eb into jaegertracing:master Sep 17, 2020
@yurishkuro yurishkuro deleted the improve-placeholder branch September 17, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seeing placeholder instead of UI
2 participants