[hotrod] Add links to traces #2536
Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov Report
@@ Coverage Diff @@
## master #2536 +/- ##
==========================================
+ Coverage 95.32% 95.35% +0.02%
==========================================
Files 208 208
Lines 9248 9248
==========================================
+ Hits 8816 8818 +2
+ Misses 355 353 -2
Partials 77 77
Continue to review full report at Codecov.
|
| @@ -85,7 +85,8 @@ <h4><em>Rides On Demand</em></h4> | |||
| var after = Date.now(); | |||
| console.log(data); | |||
| var duration = formatDuration(data.ETA); | |||
| freshCar.html('HotROD <b>' + data.Driver + '</b> arriving in ' + duration + ' [req: ' + requestID + ', latency: ' + (after-before) + 'ms]'); | |||
| var trace = 'http://localhost:16686/search?limit=20&lookback=1h&service=frontend&tags=%7B%22driver%22%3A%22' + data.Driver + '%22%7D'; | |||
There was a problem hiding this comment.
Is it too hard to add a field somewhere with the location of the Jaeger installation? Or to copy the search terms, so that people can just paste into their remote Jaeger instance?
There was a problem hiding this comment.
I'm concerned that hotrod is used in a lot of different examples and this link may not always be valid. I'd say in most cases where people are running hotrod localhost:16686 will be the Jaeger UI, but when it's not this may be confusing.
I do think this is a cool feature for demoing tracing though and wonder the same thing as @jpkrohling
Is it too hard to add a field somewhere with the location of the Jaeger installation?
There was a problem hiding this comment.
added config option -j http://localhost:16686
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Wanted to add this long time ago - a link to the trace from each request using the search URL.