Fix flaky TestReload #2624
Merged
Fix flaky TestReload #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: albertteoh <albert.teoh@logz.io>
Codecov Report
@@ Coverage Diff @@
## master #2624 +/- ##
==========================================
- Coverage 95.05% 95.04% -0.01%
==========================================
Files 209 209
Lines 9364 9368 +4
==========================================
+ Hits 8901 8904 +3
Misses 387 387
- Partials 76 77 +1
Continue to review full report at Codecov.
|
quinniup
pushed a commit
to k8battleship/jaeger
that referenced
this pull request
Nov 23, 2020
Signed-off-by: albertteoh <albert.teoh@logz.io>
quinniup
added a commit
to k8battleship/jaeger
that referenced
this pull request
Nov 23, 2020
* Bump opentelemetry-collector to v0.14.0 (jaegertracing#2617) * bump opentelemetry-collector to v0.14.0 Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> * initialize traceid and spanid explicitly Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> * fix comments and empty parent span check Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> * fasten convert traceID/spanID Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> * fix convertTraceID + fix tests Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> * Update CodeQL to latest best practices (jaegertracing#2615) This will parallelize your analysis and speed things up a bunch. Signed-off-by: jhutchings1 <jhutchings1@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> * Fix flaky TestReload (jaegertracing#2624) Signed-off-by: albertteoh <albert.teoh@logz.io> * Update x/text to v0.3.4 (jaegertracing#2625) Signed-off-by: Gary Brown <gary@brownuk.com> * Bump to latest UI for snapshot builds (jaegertracing#2626) Signed-off-by: Yuri Shkuro <github@ysh.us> * Implement anonymizer's main program (jaegertracing#2621) * Preparing release 1.21.0 (jaegertracing#2630) * updated changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * Added ui changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * Fixed UI changelog to point to 1.12.0 Signed-off-by: Joe Elliott <number101010@gmail.com> * Updated jaeger-ui to v1.12.0 Signed-off-by: Joe Elliott <number101010@gmail.com> * Resolving concerns Signed-off-by: Joe Elliott <number101010@gmail.com> * [anonymizer] Save trace in UI format (jaegertracing#2629) * Use fossa-contrib/fossa-action instead (jaegertracing#2571) * Use fossa-contrib/fossa-action instead Signed-off-by: Sora Morimoto <sora@morimoto.io> * Make step name clearer Signed-off-by: Sora Morimoto <sora@morimoto.io> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> * Update Makefile and Dockerfile for anonymizer (jaegertracing#2632) Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Fix listen IP in unit test (jaegertracing#2636) Signed-off-by: zouyu <zouy.fnst@cn.fujitsu.com> * Bump opentelemetry to v0.15.0 (jaegertracing#2634) * Bump opentelemetry to v0.15.0 Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> * add default value instead of nil value for jaegerreceiver config Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> * make lint Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> Co-authored-by: Kositsyn Pavel <vemmy124@gmail.com> Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com> Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de> Co-authored-by: Albert <26584478+albertteoh@users.noreply.github.com> Co-authored-by: Gary Brown <gary.pi4tech@gmail.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Ashmita <ashmita.bohara152@gmail.com> Co-authored-by: Joe Elliott <number101010@gmail.com> Co-authored-by: Sora Morimoto <sora@morimoto.io> Co-authored-by: ZouYu <zouy.fnst@cn.fujitsu.com> Co-authored-by: Kositsyn Pavel <kositsyn.pa@phystech.edu>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: albertteoh albert.teoh@logz.io
Which problem is this PR solving?
TestReload#2622Short description of the changes
Fixes the flaky
TestReloadtest by:keyFilelog entry, and make both assertions more specific along with diagnostic data on failure to help with debugging if the race condition presents itself again in future.Testing
Repeated the following test 3x with no errors.: