Fix issue with all-in-one build #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2669 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 213 213
Lines 9491 9491
=======================================
Hits 9027 9027
Misses 387 387
Partials 77 77 Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Nov 30, 2020
|
more undefined vars: https://github.com/jaegertracing/jaeger/runs/1472391637?check_suite_focus=true |
yurishkuro
added a commit
that referenced
this pull request
Jan 13, 2021
…ectors (#2657) * add metrics that show agent connection collector status Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * update comment Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * exec make fmt Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * simplify function and add testing relevant code in the builder_test.go Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * add comment in connect_metrics.go Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * simplify code and changed use expvar to show target Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * simplify code and changed use expvar to show target Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * exec make fmt Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix collector panic due to sarama sdk returning nil error (#2654) Signed-off-by: luhualin <luhualin@bilibili.com> Co-authored-by: luhualin <luhualin@bilibili.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix flaky tbuffered server test (#2635) * Fix flaky tbuffered server test Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> * Apply suggestions from code review - more readable comments Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Add github actions for integration tests (#2649) * Add github action for jaeger integration tests Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Create separate workflow for each integration test Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Clean-up GH action names (#2661) Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix for failures in badger integration tests (#2660) Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Add protogen validation test (#2662) Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Add github action for jaeger all-in-one image (#2663) * Add github action for jaeger all-in-one image Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Make steps self-explantory Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Fix git tags issue Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Fix ES integration test Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Update comment that looks confusing during builds Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Use GitHub actions based build badges Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix and minor improvements to all-in-one github action (#2667) Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix docker login issue with all-in-one build (#2668) * Fix docker login issue with all-in-one build Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Fix docker login issue with all-in-one build Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix issue with all-in-one build (#2669) Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Update cmd/agent/app/reporter/connect_metrics.go accept suggestions Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Update cmd/agent/app/reporter/connect_metrics.go accept suggestions Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * simplify the code that remove ConnectMetricsParams{} and integrate ConnectMetrics{} Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * simplify the code that remove ConnectMetricsParams{} and integrate ConnectMetrics{} Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * merage from the lastest master branch and exec make fmt Signed-off-by: walker.wangxy <walker.wangxy@walkerwangxydeMacBook-Pro.local> * add comment on ConnectMetrics Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * clear up redundant codes Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> Co-authored-by: WalkerWang731 <walkerwang731@gmail.com> Co-authored-by: Betula-L <N.Betula.Lu@gmail.com> Co-authored-by: luhualin <luhualin@bilibili.com> Co-authored-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Ashmita <ashmita.bohara152@gmail.com> Co-authored-by: Yuri Shkuro <github@ysh.us> Co-authored-by: walker.wangxy <walker.wangxy@walkerwangxydeMacBook-Pro.local>
bhiravabhatla
pushed a commit
to bhiravabhatla/jaeger
that referenced
this pull request
Jan 25, 2021
…ectors (jaegertracing#2657) * add metrics that show agent connection collector status Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * update comment Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * exec make fmt Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * simplify function and add testing relevant code in the builder_test.go Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * add comment in connect_metrics.go Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * simplify code and changed use expvar to show target Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * simplify code and changed use expvar to show target Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * exec make fmt Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix collector panic due to sarama sdk returning nil error (jaegertracing#2654) Signed-off-by: luhualin <luhualin@bilibili.com> Co-authored-by: luhualin <luhualin@bilibili.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix flaky tbuffered server test (jaegertracing#2635) * Fix flaky tbuffered server test Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> * Apply suggestions from code review - more readable comments Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Add github actions for integration tests (jaegertracing#2649) * Add github action for jaeger integration tests Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Create separate workflow for each integration test Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Clean-up GH action names (jaegertracing#2661) Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix for failures in badger integration tests (jaegertracing#2660) Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Add protogen validation test (jaegertracing#2662) Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Add github action for jaeger all-in-one image (jaegertracing#2663) * Add github action for jaeger all-in-one image Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Feedbacks changes Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Make steps self-explantory Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Fix git tags issue Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Fix ES integration test Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Update comment that looks confusing during builds Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Use GitHub actions based build badges Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix and minor improvements to all-in-one github action (jaegertracing#2667) Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix docker login issue with all-in-one build (jaegertracing#2668) * Fix docker login issue with all-in-one build Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> * Fix docker login issue with all-in-one build Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Fix issue with all-in-one build (jaegertracing#2669) Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Update cmd/agent/app/reporter/connect_metrics.go accept suggestions Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * Update cmd/agent/app/reporter/connect_metrics.go accept suggestions Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * simplify the code that remove ConnectMetricsParams{} and integrate ConnectMetrics{} Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * simplify the code that remove ConnectMetricsParams{} and integrate ConnectMetrics{} Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * merage from the lastest master branch and exec make fmt Signed-off-by: walker.wangxy <walker.wangxy@walkerwangxydeMacBook-Pro.local> * add comment on ConnectMetrics Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> * clear up redundant codes Signed-off-by: WalkerWang731 <wxy1990731@hotmail.com> Co-authored-by: WalkerWang731 <walkerwang731@gmail.com> Co-authored-by: Betula-L <N.Betula.Lu@gmail.com> Co-authored-by: luhualin <luhualin@bilibili.com> Co-authored-by: Pavel Kositsyn <kositsyn.pa@phystech.edu> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Co-authored-by: Ashmita <ashmita.bohara152@gmail.com> Co-authored-by: Yuri Shkuro <github@ysh.us> Co-authored-by: walker.wangxy <walker.wangxy@walkerwangxydeMacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashmita Bohara ashmita.bohara152@gmail.com
Which problem is this PR solving?
Remove any travis related variable
Fix for #2668 (comment)
/cc @yurishkuro