2814 - Throw an error when --es.use-ilm is set without --es.use-aliases

[bhiravabhatla]

Signed-off-by: santosh bsantosh@thoughtworks.com

Resolves #2814

Which problem is this PR solving?

• Adds a check to make sure that --es.use-ilm is always used in conjunction with--es.use-aliases

Short description of the changes

Add validation at the top of each ES reader and writer constructor with the following logic:

if cfg.GetUseILM() && !cfg.GetUseReadWriteAliases() {
return nil, fmt.Errorf("the error message")
}

[codecov]

Codecov Report

Merging #2820 (56ed8ac) into master (cc3c8e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2820   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files         221      221           
  Lines        9693     9697    +4     
=======================================
+ Hits         9300     9304    +4     
  Misses        324      324           
  Partials       69       69           

Impacted Files	Coverage Δ
plugin/storage/es/factory.go	98.21% <100.00%> (+0.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3c8e3...711dac8. Read the comment docs.

[yurishkuro]

Thanks!