Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Content-Type in healthcheck's http response #2926

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Set Content-Type in healthcheck's http response #2926

merged 1 commit into from
Apr 6, 2021

Conversation

logeable
Copy link
Contributor

@logeable logeable commented Apr 6, 2021

Signed-off-by: logeable logeable@gmail.com

Which problem is this PR solving?

Short description of the changes

  • set header before call WriteHeader

Signed-off-by: logeable <logeable@gmail.com>
@logeable logeable requested a review from a team as a code owner April 6, 2021 16:10
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #2926 (efe7ddb) into master (33e8e96) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2926      +/-   ##
==========================================
+ Coverage   95.91%   95.94%   +0.03%     
==========================================
  Files         223      223              
  Lines        9708     9708              
==========================================
+ Hits         9311     9314       +3     
+ Misses        327      326       -1     
+ Partials       70       68       -2     
Impacted Files Coverage Δ
pkg/healthcheck/handler.go 100.00% <100.00%> (ø)
...lugin/sampling/strategystore/adaptive/processor.go 99.07% <0.00%> (-0.93%) ⬇️
cmd/query/app/server.go 97.08% <0.00%> (+1.45%) ⬆️
cmd/query/app/static_handler.go 96.77% <0.00%> (+1.61%) ⬆️
cmd/collector/app/server/zipkin.go 76.92% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e8e96...efe7ddb. Read the comment docs.

@yurishkuro yurishkuro changed the title fix http response header Set Content-Type in healthcheck's http response Apr 6, 2021
@yurishkuro yurishkuro merged commit c3fc31d into jaegertracing:master Apr 6, 2021
@yurishkuro
Copy link
Member

Thanks!

@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The response ContentType of HealthCheck.Handler is not application/json
3 participants