Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify FindTraces() received a query #2979

Merged
merged 3 commits into from
May 6, 2021

Conversation

esnible
Copy link
Contributor

@esnible esnible commented May 5, 2021

Fixes a problem where FindTraces misbehaves if sent no query.

Signed-off-by: Ed Snible <snible@us.ibm.com>
@esnible esnible requested a review from a team as a code owner May 5, 2021 17:18
@esnible esnible requested a review from vprithvi May 5, 2021 17:18
@mergify mergify bot requested a review from jpkrohling May 5, 2021 17:19
Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Ed Snible <snible@us.ibm.com>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #2979 (ef6938f) into master (87f1283) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2979   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         223      223           
  Lines        9718     9720    +2     
=======================================
+ Hits         9325     9327    +2     
  Misses        325      325           
  Partials       68       68           
Impacted Files Coverage Δ
cmd/query/app/grpc_handler.go 97.33% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f1283...ef6938f. Read the comment docs.

@yurishkuro yurishkuro merged commit f076065 into jaegertracing:master May 6, 2021
@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants