Set lookback in ES rollover to distant past #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3169 +/- ##
==========================================
+ Coverage 95.91% 95.94% +0.02%
==========================================
Files 239 239
Lines 14649 14655 +6
==========================================
+ Hits 14051 14061 +10
+ Misses 520 518 -2
+ Partials 78 76 -2
Continue to review full report at Codecov.
|
albertteoh
reviewed
Jul 29, 2021
albertteoh
reviewed
Jul 29, 2021
| // In rollover only read alias is used to query the data so looking far into the past should | ||
| // not affect performance. | ||
| if p.UseReadWriteAliases { | ||
| maxSpanAge = time.Hour * 24 * 365 * 100 |
There was a problem hiding this comment.
I think we should extend TestNewSpanReader, maybe converting it to a table-driven test, to prevent a regression on this functionality.
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
force-pushed
the
es-rollover-maxage
branch
from
3783edb
to
f13cd83
Compare
|
@albertteoh PR updated |
albertteoh
reviewed
Aug 5, 2021
| for _, test := range tests { | ||
| t.Run(test.name, func(t *testing.T) { | ||
| reader := NewSpanReader(test.params) | ||
| require.NotNil(t, reader) |
There was a problem hiding this comment.
i think you're missing the assertion on test.maxSpanAge here (I would rename it test.wantMaxSpanAge to make it clear it's the expected value)?
albertteoh
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3152
@albertteoh could you please review?