Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing package integration from coverage reports #3357

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

rbroggi
Copy link
Contributor

@rbroggi rbroggi commented Oct 30, 2021

Which problem is this PR solving?

  • Make coverage reports more accurate

Short description of the changes

  • Package integration is a test-only package for integration tests. The files integration.go and trace_compare.go bundle test-utilities and therefore should not be considered for coverage reports (quite in the same way *_test.go files are not eligible too).

Signed-off-by: rbroggi <ro_broggi@hotmail.com>
@rbroggi rbroggi requested a review from a team as a code owner October 30, 2021 15:06
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #3357 (bdbeea4) into master (8b7772e) will increase coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3357      +/-   ##
==========================================
+ Coverage   96.01%   96.43%   +0.41%     
==========================================
  Files         261      259       -2     
  Lines       15464    15166     -298     
==========================================
- Hits        14848    14625     -223     
+ Misses        523      456      -67     
+ Partials       93       85       -8     
Impacted Files Coverage Δ
cmd/collector/app/server/zipkin.go 68.29% <0.00%> (-2.44%) ⬇️
cmd/query/app/server.go 94.11% <0.00%> (-1.48%) ⬇️
plugin/storage/badger/spanstore/reader.go 95.50% <0.00%> (-0.71%) ⬇️
plugin/storage/integration/integration_test.go
plugin/storage/integration/trace_compare_test.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b7772e...bdbeea4. Read the comment docs.

…ey can be naturally excluded from coverage reports

Signed-off-by: rbroggi <ro_broggi@hotmail.com>
@rbroggi rbroggi changed the title Removing package integration from coverability reports Removing package integration from coverage reports Oct 30, 2021
@yurishkuro yurishkuro merged commit 77e5674 into jaegertracing:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants