Limit URL size in Elasticsearch index delete request

[jkandasa]

Signed-off-by: Jeeva Kandasamy jkandasa@gmail.com

Which problem is this PR solving?

• Resolves es index deletion failed with too_long_frame_exception #3374

[jkandasa]

@pavolloffay can you please review this PR?

[pavolloffay]

It would be great if you could add as well integration test for this to https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/integration/es_index_cleaner_test.go

[jkandasa]

It would be great if you could add as well integration test for this to https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/integration/es_index_cleaner_test.go

@pavolloffay I do not see an option to create indices with past creation_time.
Can you guide me to get those? Thanks!

[codecov]

Codecov Report

Merging #3375 (1c5dfee) into master (745587a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3375      +/-   ##
==========================================
+ Coverage   96.45%   96.49%   +0.04%     
==========================================
  Files         260      260              
  Lines       15199    15215      +16     
==========================================
+ Hits        14660    14682      +22     
+ Misses        455      450       -5     
+ Partials       84       83       -1     

Impacted Files	Coverage Δ
pkg/es/client/index_client.go	92.81% <100.00%> (+0.09%)	⬆️
cmd/query/app/static_handler.go	95.80% <0.00%> (ø)
pkg/config/tlscfg/cert_watcher.go	94.73% <0.00%> (+2.10%)	⬆️
cmd/collector/app/server/zipkin.go	70.73% <0.00%> (+12.19%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745587a...1c5dfee. Read the comment docs.

[jkandasa]

@pavolloffay I have added additional unit tests to cover the es index delete functionality

[pavolloffay]

@pavolloffay I do not see an option to create indices with past creation_time.
Can you guide me to get those? Thanks!

IIRC that is not required to test this feature.

[pavolloffay]

thanks @jkandasa for the contribution