Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system diagram using mermaid markdown #3529

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Feb 14, 2022

@yurishkuro yurishkuro requested a review from a team as a code owner February 14, 2022 20:41
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
Copy link
Member Author

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #3529 (4f6126f) into main (aa4c2e6) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3529      +/-   ##
==========================================
+ Coverage   96.44%   96.48%   +0.03%     
==========================================
  Files         263      263              
  Lines       15376    15376              
==========================================
+ Hits        14830    14836       +6     
+ Misses        461      456       -5     
+ Partials       85       84       -1     
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 95.80% <0.00%> (+1.79%) ⬆️
pkg/config/tlscfg/cert_watcher.go 94.73% <0.00%> (+2.10%) ⬆️
cmd/collector/app/server/zipkin.go 70.73% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4c2e6...4f6126f. Read the comment docs.

Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it :) However, in dark mode the README.md file looks a bit like a big black hole.

image

Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Very cool!

@yurishkuro yurishkuro merged commit 51e9b26 into main Feb 15, 2022
@yurishkuro yurishkuro deleted the yurishkuro-patch-1 branch May 16, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants