Ignore the problem of self-reported spans when multi-tenant enabled #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3787 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 288 288
Lines 16774 16778 +4
=======================================
+ Hits 16370 16374 +4
Misses 319 319
Partials 85 85
Continue to review full report at Codecov.
|
yurishkuro
previously approved these changes
Jun 29, 2022
pavolloffay
reviewed
Jun 29, 2022
| r.logger.Error("Could not send spans over gRPC", zap.Error(err)) | ||
| stat, ok := status.FromError(err) | ||
| if ok && stat.Code() == codes.PermissionDenied && stat.Message() == "missing tenant header" { | ||
| r.logger.Debug("Could not send spans over gRPC", zap.Error(err)) |
There was a problem hiding this comment.
It's worth distinguishing the error messages a bit more, not just by the error level.
auto-merge was automatically disabled
June 29, 2022 16:35
Head branch was pushed to by a user without write access
yurishkuro
reviewed
Jun 29, 2022
Comment on lines
209
to
210
| conn, err := grpc.Dial(addr.String(), grpc.WithTransportCredentials(insecure.NewCredentials())) | ||
| //nolint:staticcheck // don't care about errors | ||
| defer conn.Close() | ||
| require.NoError(t, err) |
There was a problem hiding this comment.
Suggested change
| conn, err := grpc.Dial(addr.String(), grpc.WithTransportCredentials(insecure.NewCredentials())) | |
| //nolint:staticcheck // don't care about errors | |
| defer conn.Close() | |
| require.NoError(t, err) | |
| conn, err := grpc.Dial(addr.String(), grpc.WithTransportCredentials(insecure.NewCredentials())) | |
| require.NoError(t, err) | |
| defer func() { require.NoError(t, conn.Close()) }() |
yurishkuro
reviewed
Jun 29, 2022
| require.NoError(t, err) | ||
| rep := NewReporter(conn, nil, zap.NewNop()) | ||
|
|
||
| tm := time.Unix(158, 0) |
Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Ed Snible <snible@us.ibm.com>
Signed-off-by: Ed Snible <snible@us.ibm.com>
esnible
force-pushed
the
less-tenancy-logging
branch
from
94fbe7d
to
de43533
Compare
pavolloffay
approved these changes
Jul 1, 2022
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Jul 13, 2022
…aegertracing#3787) * Log missing tenancy at debug level Signed-off-by: Ed Snible <snible@us.ibm.com> * Debug message and code coverage Signed-off-by: Ed Snible <snible@us.ibm.com> * Simplify test Signed-off-by: Ed Snible <snible@us.ibm.com> Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ed Snible snible@us.ibm.com
If the experimental tenancy feature is enabled, every self-reported span generates two error level log entries with full stack traces.
This PR causes Jaeger to log missing tenancy at debug level.
The goal is to mitigate the problem of self-reports while we focus on adding tenancy to the query APIs.
See #3750 (comment)