Add the signing of releases to build process #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jkowall <jkowall@kowall.net>
Codecov ReportBase: 97.18% // Head: 97.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4033 +/- ##
==========================================
- Coverage 97.18% 97.17% -0.02%
==========================================
Files 295 295
Lines 17390 17390
==========================================
- Hits 16901 16898 -3
- Misses 394 396 +2
- Partials 95 96 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jkowall
changed the title
yurishkuro
reviewed
Nov 9, 2022
|
One missing step if you want to add the key into the keyserver: gpg --keyserver pgp.mit.edu --send-key 79FAF16A8C42B3593143DD7C8DE95E7E9BC9CA3C |
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Jonah Kowall <jkowall@gmail.com>
yurishkuro
approved these changes
Nov 9, 2022
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this pull request
Mar 5, 2023
Signed-off-by: jkowall <jkowall@kowall.net> ## Which problem is this PR solving? Resolves jaegertracing#3960 ## Short description of the changes This adds in signing to the build process, the following steps must be taken to configure 2 new secrets in the repo by another team member. 1. Generate a GPG key : gpg --gen-key Answer the prompts accordingly for the email specified (you can set a password as well) 2. pgp --list-keys Find the GUID for the key you want to use ex: 79FAF16A8C42B3593143DD7C8DE95E7E9BC9CA3C 3. Get the contents of the key: gpg --export-secret-keys -a 8DE95E7E9BC9CA3C 4. Copy and paste (or pipe to a file and use that). This should be added as a secret called GPG_PRIVATE_KEY 5. The password you created should be added as a secret called GPG_PASSWORD Please let me know if you have questions. We can either re-run the last build or wait for the next release to test it. Signed-off-by: jkowall <jkowall@kowall.net> Signed-off-by: Jonah Kowall <jkowall@gmail.com> Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jkowall jkowall@kowall.net
Which problem is this PR solving?
Resolves #3960
Short description of the changes
This adds in signing to the build process, the following steps must be taken to configure 2 new secrets in the repo by another team member.
Generate a GPG key : gpg --gen-key
Answer the prompts accordingly for the email specified (you can set a password as well)
pgp --list-keys
Find the GUID for the key you want to use ex: 79FAF16A8C42B3593143DD7C8DE95E7E9BC9CA3C
Get the contents of the key: gpg --export-secret-keys -a 8DE95E7E9BC9CA3C
Copy and paste (or pipe to a file and use that). This should be added as a secret called GPG_PRIVATE_KEY
The password you created should be added as a secret called GPG_PASSWORD
Please let me know if you have questions. We can either re-run the last build or wait for the next release to test it.