[ci]: skipping debug builds when not making a release #4496
Conversation
Signed-off-by: pushpak <puspak9208@gmail.com> fix(docker img build): skipping debug builds when not a release
|
@yurishkuro please review the PR and suggest changes. |
There was a problem hiding this comment.
Another place where debug images are built is scripts/build-upload-docker-images.sh
Note that that script already accepts pr-only argument, so we can adjust it directly to exclude debug logic for pr-only, without any changes to the workflows. And for consistency we should implement a similar flag for scripts/build-all-in-one-image.sh, instead of the new SKIP_DEBUG variable.
scripts/build-all-in-one-image.sh
Outdated
| #build all-in-one-debug image and upload to dockerhub/quay.io | ||
| bash scripts/build-upload-a-docker-image.sh -b -c all-in-one-debug -d cmd/all-in-one -t debug | ||
| else | ||
| echo "Skipping debug commands" |
There was a problem hiding this comment.
looks like this should be in the then part
| @@ -48,3 +48,4 @@ jobs: | |||
| env: | |||
| DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }} | |||
| QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }} | |||
| SKIP_DEBUG: ${{inputs.SKIP_DEBUG}} | |||
There was a problem hiding this comment.
We don't run actions manually. The main release is done by .github/workflows/ci-release.yml, so there it should be enabling debug builds, and here they should be explicitly disabled.
|
Got them all, working on it |
Signed-off-by: pushpak <puspak9208@gmail.com>
Signed-off-by: pushpak <puspak9208@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4496 +/- ##
=======================================
Coverage 97.05% 97.06%
=======================================
Files 300 300
Lines 17813 17813
=======================================
+ Hits 17289 17290 +1
+ Misses 420 419 -1
Partials 104 104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
changed the title
## Which problem is this PR solving? - There was a bug introduced in #4496 where `pr-only` mode was used unconditionally, instead of for PRs-only. ## Description of the changes - fork the build step into on-main and no-on-main Signed-off-by: Yuri Shkuro <github@ysh.us>
Adjusted the build scripts to skip building debug versions unless the GH actions runs for a release by including a SKIP_DEBUG variable in command.
Resolves #4471