[hotrod] Reduce span exporter's batch timeout to let the spans be exported sooner #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In HotROD appbatching is not required it should export traces asap so BatchTimeOut value can be lowered from 5sec solves the issue Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com>
yurishkuro
changed the title
yurishkuro
approved these changes
Jun 8, 2023
albertteoh
reviewed
Jun 8, 2023
| @@ -62,7 +63,7 @@ func Init(serviceName string, exporterType string, metricsFactory metrics.Factor | |||
| rpcmetricsObserver := rpcmetrics.NewObserver(metricsFactory, rpcmetrics.DefaultNameNormalizer) | |||
|
|
|||
| tp := sdktrace.NewTracerProvider( | |||
| sdktrace.WithBatcher(exp), | |||
| sdktrace.WithBatcher(exp, sdktrace.WithBatchTimeout(1000*time.Millisecond)), | |||
There was a problem hiding this comment.
nit: could express this as time.Second.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4518 +/- ##
==========================================
- Coverage 97.08% 97.05% -0.03%
==========================================
Files 300 300
Lines 17813 17813
==========================================
- Hits 17293 17289 -4
- Misses 417 420 +3
- Partials 103 104 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kjschnei001
pushed a commit
to kjschnei001/jaeger
that referenced
this pull request
Jun 29, 2023
…orted sooner (jaegertracing#4518) In HotROD appbatching is not required it should export traces asap so BatchTimeOut value can be lowered from 5sec solves the issue Resolves jaegertracing/jaeger-ui#1180 Signed-off-by: GLVS Kiriti <glvskiriti2003369@gmail.com> Signed-off-by: KevinSchneider <kevin.schneider@target.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HotROD appbatching is not required it should export traces asap so BatchTimeOut value can be lowered from 5sec solves the issue
Resolves jaegertracing/jaeger-ui#1180