Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotrod] Handle both OT and OTEL baggage #4572

Merged
merged 1 commit into from
Jul 6, 2023
Merged

[hotrod] Handle both OT and OTEL baggage #4572

merged 1 commit into from
Jul 6, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jul 6, 2023 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • Move explicit baggage access into a util func that checks both OT and OTEL baggage. Later the OT part can be retired completely.
  • Update usage sites to use the new function instead of OT Span.BaggageItem

A couple of less related changes in tracing/mutex.go:

  • Use OTEL Span API instead of OT
  • Replace direct-to-span logging with the regular logger that logs both to stdout and to the span

@yurishkuro
[hotrod] Handle both OT and OTEL baggage
cfc8b76 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner July 6, 2023 20:26
@yurishkuro yurishkuro requested a review from vprithvi July 6, 2023 20:26
@yurishkuro yurishkuro merged commit ee6cc41 into jaegertracing:main Jul 6, 2023
29 checks passed
@yurishkuro yurishkuro deleted the hotrod-baggage branch July 6, 2023 20:38
afzal442 pushed a commit to Cloud-Hacks/jaeger that referenced this pull request Jul 10, 2023
@yurishkuro @afzal442
[hotrod] Handle both OT and OTEL baggage (jaegertracing#4572)
6d5c41b 
## Which problem is this PR solving?
- Part of jaegertracing#3380

## Short description of the changes
- Move explicit baggage access into a util func that checks both OT and
OTEL baggage. Later the OT part can be retired completely.
- Update usage sites to use the new function instead of OT
`Span.BaggageItem`

A couple of less related changes in `tracing/mutex.go`:
- Use OTEL Span API instead of OT
- Replace direct-to-span logging with the regular logger that logs both
to stdout and to the span

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vprithvi vprithvi Awaiting requested review from vprithvi vprithvi is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yurishkuro