Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotrod] Stop supporting "jaeger" exporter #4719

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • otel/exporters/jaeger is deprecated

Description of the changes

  • Removes the option to export jaeger format from hotrod

How was this change tested?

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner September 4, 2023 12:41
albertteoh
albertteoh previously approved these changes Sep 4, 2023
Signed-off-by: Yuri Shkuro <github@ysh.us>
cobra.OnInitialize(onInitialize)
}

// onInitialize is called before the command is executed.
func onInitialize() {
rand.Seed(int64(time.Now().Nanosecond()))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecated

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit be0a7fc into jaegertracing:main Sep 4, 2023
31 checks passed
@yurishkuro yurishkuro deleted the otel2 branch September 4, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants