Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci-release] Improve release workflow for manual runs #4818

Merged
merged 2 commits into from
Oct 7, 2023
Merged

[ci-release] Improve release workflow for manual runs #4818

merged 2 commits into from
Oct 7, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Set BRANCH=s/main/main_from_fork/ when running on pull requests. This should solve the problem with CI failing when people submit a PR from a main branch in their fork, because our CI scripts think it means docker images should be uploaded and fail on the lack of credentials. Now they will skip the uploads.
  • Move cleanup of android toolchain to the top of the workflow
  • Replace the use of .github/actions/setup-branch with custom logic to set BRANCH which is always based on the recent semver tag. setup-branch will still work for non-release workflows.
  • Remove unnecessary success checks in the steps (job fails when any step fails)
  • Use env.BRANCH as release name in upload-release-action action, instead of github.ref
  • Manually upload SBOM to the correct release (to solve [ci-release] SBOM not uploaded #4817)

How was this change tested?

  • Will have to run ci-release manually after merge

@yurishkuro
[ci-release] Improve release workflow for manual runs
907f57d 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner October 7, 2023 19:50
@yurishkuro
cleanup
9816649 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit a6d091d into jaegertracing:main Oct 7, 2023
28 of 29 checks passed
@yurishkuro yurishkuro deleted the release-wf branch October 7, 2023 21:10
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertteoh albertteoh albertteoh approved these changes

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ci-release] SBOM not uploaded [cu-release] Release artifacts can be uploaded to the wrong release / tag
2 participants
@yurishkuro @albertteoh