Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --force to docker commands #4820

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

albertteoh
Copy link
Contributor

@albertteoh albertteoh commented Oct 7, 2023

Description of the changes

  • docker prune commands will, by default, prompt the caller whether if they want to proceed, while defaulting to N, which resulted in a no-op in this recent CI run.
  • Adding a --force flag defaults to y without a prompt.

How was this change tested?

  • Tested locally in terminal.

Checklist

Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
@albertteoh albertteoh requested a review from a team as a code owner October 7, 2023 20:19
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

see 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit 9d512a1 into jaegertracing:main Oct 7, 2023
31 checks passed
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants