Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTel resource detector to Jaeger components #4864

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

james-ryans
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Add OTel resources to Jaeger components and tracegen tool.

How was this change tested?

  • Tested manually in local
image image

Checklist

Signed-off-by: James Ryans <james.ryans2012@gmail.com>
Signed-off-by: James Ryans <james.ryans2012@gmail.com>
@james-ryans james-ryans requested a review from a team as a code owner October 19, 2023 15:05
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@james-ryans
Copy link
Contributor Author

Hi @yurishkuro, I'm not sure if I have covered all the SDK traces with the OTel detector resource. Can you point out any that I may have missed? Thanks! Also I'll update jaeger-ui's SDK trace later.

@yurishkuro yurishkuro enabled auto-merge (squash) October 19, 2023 15:40
@yurishkuro yurishkuro merged commit b0826a9 into jaegertracing:main Oct 19, 2023
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTEL] Process info is missing from the spans
2 participants