Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Enable linting of code in examples/ #4880

Merged
merged 2 commits into from
Oct 22, 2023
Merged

ci: Enable linting of code in examples/ #4880

merged 2 commits into from
Oct 22, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • The HotROD source code was never formatted or linted because golangci-lint was automatically excluding /examples/

Description of the changes

  • Disable linter's default skip dirs (which include /examples/)
  • Fix linter errors

@yurishkuro
ci: Enable linting of code in examples/
ad90ab2 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner October 22, 2023 01:39
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Oct 22, 2023
@yurishkuro
nocover
efa732f 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
examples/hotrod/pkg/tracing/rpcmetrics/metrics.go 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit 74f3488 into jaegertracing:main Oct 22, 2023
33 checks passed
@yurishkuro yurishkuro deleted the lint-examples branch October 22, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yurishkuro