Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add blackhole storage, for benchmarking #4896

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • When benchmarking jaeger-v2 vs. jaeger-collector, it's useful to have a no-op storage.

Description of the changes

  • Add blackhole storage type.

How was this change tested?

  • unit tests

Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
plugin/storage/blackhole/blackhole.go 100.00% <100.00%> (ø)
plugin/storage/blackhole/factory.go 100.00% <100.00%> (ø)
plugin/storage/factory.go 98.41% <100.00%> (+0.01%) ⬆️
plugin/storage/factory_config.go 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blackhole storage is a cool name, although "no-op" storage is immediately intuitive to me, probably because it's a common parlance.

@yurishkuro
Copy link
Member Author

I was going for cool.

@yurishkuro yurishkuro merged commit 2aa0d90 into jaegertracing:main Oct 26, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants