Separate all-in-one integration tests for v1 and v2 #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added
the
changelog:ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4968 +/- ##
==========================================
+ Coverage 95.58% 95.60% +0.02%
==========================================
Files 317 317
Lines 18689 18689
==========================================
+ Hits 17863 17868 +5
+ Misses 663 659 -4
+ Partials 163 162 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
changed the title
yurishkuro
changed the title
yurishkuro
commented
Nov 26, 2023
| t.Run("createTrace", createTrace) | ||
| t.Run("getAPITrace", getAPITrace) | ||
| t.Run("getSamplingStrategy", getSamplingStrategy) | ||
| t.Run("getServicesAPIV3", getServicesAPIV3) | ||
| } | ||
|
|
||
| func healthCheck(t *testing.T) { |
There was a problem hiding this comment.
moved two methods from below to match the order of calls from the test above
jkowall
approved these changes
Nov 27, 2023
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
cmd/jaeger/internal/all-in-one/packageHow was this change tested?