Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example/grafana-integration #4980

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

angristan
Copy link
Contributor

Which problem is this PR solving?

Currently, the grafana-integration example doesn't work properly: if you run docker-compose up in that folder, services will start but only logging will work, the metrics and tracing won't.

Description of the changes

  • Fix traces endpoint config for hotrod (traces export: Post "http://localhost:4318/v1/traces": dial tcp 127.0.0.1:4318: connect: connection refused)
  • Fix hotrod metrics scraping (endpoint has moved to the frontend service)
  • Pin Jaeger/hotrod tags to prevent future issues
  • Fix Grafana dashboard (metric names, labels, migrate to new time series panel)
  • Add default Grafana credentials to README
  • Fix the loki container being stuck on shutdown by setting shorter timeouts (bug with the driver: if loki is not reachable and loki-docker-driver is activated, containers apps stops and cannot be stopped/killed grafana/loki#2361 (comment))
  • Update Grafana/Loki/Prom pinned versions (especially to get Grafana UI improvements)

How was this change tested?

docker-compose up 🙂

SCR-20231201-cohy SCR-20231201-cxos SCR-20231201-coke

Checklist

* Update Grafana/Loki/Prom pinned versions (especially to get Grafana UI improvements)
* Pin Jaeger/hotrod tags to prevent future issues
* Fix traces endpoint config for hotrod (traces export: Post "http://localhost:4318/v1/traces":
  dial tcp 127.0.0.1:4318: connect: connection refused)
* Fix hotrod metrics scraping (endpoint has moved to the frontend service)
* Fix Grafana dashboard (metric names, labels, migrate to new time series panel)
* Add default Grafana credentials to README
* Fix the loki container being stuck on shutdown by setting shorter
  timeouts (bug with the driver: grafana/loki#2361 (comment))

Signed-off-by: Stanislas Lange <git@slange.me>
@angristan angristan requested a review from a team as a code owner December 1, 2023 01:35
@yurishkuro
Copy link
Member

Thanks for the fixes.

Could you elaborate on the value you're getting from this example? It seems 99% about Grafana, Jaeger almost not needed or used. I am tempted to delete this example altogether.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dd4b60) 95.62% compared to head (96e5315) 95.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4980      +/-   ##
==========================================
- Coverage   95.62%   95.59%   -0.03%     
==========================================
  Files         319      319              
  Lines       18760    18760              
==========================================
- Hits        17939    17934       -5     
- Misses        659      663       +4     
- Partials      162      163       +1     
Flag Coverage Δ
cassandra-3.x 25.64% <ø> (ø)
cassandra-4.x 25.64% <ø> (ø)
elasticsearch-5.x 19.90% <ø> (-0.02%) ⬇️
elasticsearch-6.x 19.90% <ø> (-0.02%) ⬇️
elasticsearch-7.x 20.05% <ø> (ø)
elasticsearch-8.x 20.12% <ø> (-0.02%) ⬇️
grpc-badger 19.53% <ø> (-0.02%) ⬇️
kafka 14.07% <ø> (ø)
opensearch-1.x 20.03% <ø> (-0.02%) ⬇️
opensearch-2.x 20.05% <ø> (ø)
unittests 93.35% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angristan
Copy link
Contributor Author

Sure :) Well, I would agree Prometheus + Loki might not be relevant in this context indeed. We could probably delete them from the example to keep it leaner.
However, the value I got from it was to see how Grafana could use Jaeger as a data source, I'm pretty pleased with the result.

I'm happy to rework the MR and remove Loki and Prometheus, but feel free to close it if you want to delete it altogether 👍

@yurishkuro yurishkuro merged commit e170dba into jaegertracing:main Dec 1, 2023
37 of 38 checks passed
@yurishkuro
Copy link
Member

@angristan do you know if it's possible to configure Grafana to open Jaeger UI for traces instead of the built-in view? I don't mind metrics & logs, it's the trace view that bug me, because it effectively shows "this is how you don't need to use Jaeger" (even though it's still used for storage, but not the UI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants