Allow specifying version for HotROD docker-compose #5011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
albertteoh
approved these changes
Dec 18, 2023
| @@ -1,7 +1,11 @@ | |||
| version: '3.7' | |||
|
|
|||
| # To run a specific version of Jaeger, use environment variable, e.g.: | |||
| # JAEGER_VERSION=1.52 docker compose up | |||
There was a problem hiding this comment.
Perhaps we should move this into https://github.com/jaegertracing/jaeger/tree/main/examples/hotrod#run-everything-via-docker-compose (and also update the command)?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5011 +/- ##
==========================================
- Coverage 95.61% 95.60% -0.02%
==========================================
Files 319 319
Lines 18786 18786
==========================================
- Hits 17962 17960 -2
- Misses 661 663 +2
Partials 163 163
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
examples/hotrod/docker-compose.ymlalways usedlatesttag, which is not being refreshed by Docker unless you proactively do that. There was no way to override that.Description of the changes
JAEGER_VERSIONenvironment variableHow was this change tested?
latesttags were pointing to stale versions, and the example was not actually working (likely due to earlier changes to introducing OTEL SDK)$ JAEGER_VERSION=1.52 docker compose updownloaded new versions and the tracing was working