Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goleak check to cmd/agent/app/configmanager #5015

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Add goleak check
  • Call Stop on the factory for clean shutdown
  • Run each test via t.Run so that defer runs in scope

cc @akagami-harsh

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner December 18, 2023 17:46
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b42cf7) 95.60% compared to head (64ffd12) 95.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5015   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         319      319           
  Lines       18786    18786           
=======================================
  Hits        17960    17960           
  Misses        663      663           
  Partials      163      163           
Flag Coverage Δ
cassandra-3.x 25.63% <ø> (ø)
cassandra-4.x 25.63% <ø> (ø)
elasticsearch-5.x 19.90% <ø> (ø)
elasticsearch-6.x 19.90% <ø> (+0.01%) ⬆️
elasticsearch-7.x 20.02% <ø> (-0.02%) ⬇️
elasticsearch-8.x 20.13% <ø> (+0.01%) ⬆️
grpc-badger 19.52% <ø> (ø)
kafka 14.12% <ø> (ø)
opensearch-1.x 20.04% <ø> (+0.01%) ⬆️
opensearch-2.x 20.02% <ø> (-0.02%) ⬇️
unittests 93.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro enabled auto-merge (squash) December 19, 2023 00:30
@yurishkuro yurishkuro merged commit 4113075 into jaegertracing:main Dec 19, 2023
37 checks passed
@yurishkuro yurishkuro deleted the configmanager-goleak branch December 19, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants