Fix goroutine leaks in several packages #5026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added
the
changelog:ci
yurishkuro
commented
Dec 22, 2023
| @@ -84,11 +89,6 @@ func initHelper( | |||
| // span processor to aggregate spans before export. | |||
| bsp := sdktrace.NewBatchSpanProcessor(traceExporter) | |||
|
|
|||
| res, err := otelResource(ctx, svc) | |||
| if err != nil { | |||
| return nil, err | |||
There was a problem hiding this comment.
this was leaking exporter created above. Better to create resource first since it doesn't start any background work.
yurishkuro
commented
Dec 22, 2023
| @@ -90,6 +85,11 @@ func (f *Factory) Initialize(metricsFactory metrics.Factory, logger *zap.Logger) | |||
| default: | |||
| return errors.New("kafka encoding is not one of '" + EncodingJSON + "' or '" + EncodingProto + "'") | |||
| } | |||
| p, err := f.NewProducer(logger) | |||
There was a problem hiding this comment.
producer starts bg activity so create it last
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5026 +/- ##
==========================================
+ Coverage 95.61% 95.62% +0.01%
==========================================
Files 319 319
Lines 18786 18793 +7
==========================================
+ Hits 17962 17971 +9
+ Misses 661 660 -1
+ Partials 163 162 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?