Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Set pipefail when running unit tests to preserve exit code #5057

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Use set -o pipefail as we did in all other targets where the test output is piped into something

How was this change tested?

  • Ran local validation to ensure that error code is returned with this change

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner December 28, 2023 17:41
@yurishkuro yurishkuro added changelog:ci Change related to continuous integration / testing bug labels Dec 28, 2023
@yurishkuro yurishkuro changed the title Set pipefail when running unit tests bugfix: Set pipefail when running unit tests Dec 28, 2023
@yurishkuro yurishkuro changed the title bugfix: Set pipefail when running unit tests bugfix: Set pipefail when running unit tests to preserve exit code Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bdd43f7) 95.56% compared to head (cd8ea2a) 95.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5057      +/-   ##
==========================================
- Coverage   95.56%   95.53%   -0.04%     
==========================================
  Files         313      313              
  Lines       18160    18160              
==========================================
- Hits        17355    17349       -6     
- Misses        645      649       +4     
- Partials      160      162       +2     
Flag Coverage Δ
cassandra-3.x 25.61% <ø> (ø)
cassandra-4.x 25.61% <ø> (ø)
elasticsearch-5.x 19.88% <ø> (ø)
elasticsearch-6.x 19.88% <ø> (ø)
elasticsearch-7.x 20.02% <ø> (ø)
elasticsearch-8.x 20.09% <ø> (-0.02%) ⬇️
grpc-badger 19.51% <ø> (+0.01%) ⬆️
kafka 14.10% <ø> (-13.41%) ⬇️
opensearch-1.x 20.02% <ø> (ø)
opensearch-2.x 20.00% <ø> (ø)
unittests 93.19% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 84e7b69 into jaegertracing:main Dec 28, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants