Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remnants of internal OTLP types #5107

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jan 15, 2024

Description of the changes

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:breaking-change Change that is breaking public APIs or established behavior label Jan 15, 2024
Copy link

Test Results

2 060 tests   - 25   2 050 ✅  - 25   1m 9s ⏱️ -1s
  216 suites  -  4      10 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 5ac0127. ± Comparison against base commit c1e72fc.

This pull request removes 25 tests.
github.com/jaegertracing/jaeger/model/v2 ‑ TestMarshal
github.com/jaegertracing/jaeger/model/v2 ‑ TestMarshal/Valid_span_id
github.com/jaegertracing/jaeger/model/v2 ‑ TestMarshal/Valid_trace_id
github.com/jaegertracing/jaeger/model/v2 ‑ TestMarshalSpan
github.com/jaegertracing/jaeger/model/v2 ‑ TestMarshalSpan/invalid_IDs/JSON
github.com/jaegertracing/jaeger/model/v2 ‑ TestMarshalSpan/invalid_IDs/Protobuf
github.com/jaegertracing/jaeger/model/v2 ‑ TestMarshalSpan/valid_IDs/JSON
github.com/jaegertracing/jaeger/model/v2 ‑ TestMarshalSpan/valid_IDs/Protobuf
github.com/jaegertracing/jaeger/model/v2 ‑ TestMarshalTo
github.com/jaegertracing/jaeger/model/v2 ‑ TestMarshalTo/Invalid_span_id_buffer
…

@yurishkuro yurishkuro marked this pull request as ready for review January 15, 2024 21:24
@yurishkuro yurishkuro requested a review from a team as a code owner January 15, 2024 21:24
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (126c49b) 94.46% compared to head (5ac0127) 95.56%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5107      +/-   ##
==========================================
+ Coverage   94.46%   95.56%   +1.10%     
==========================================
  Files         320      317       -3     
  Lines       18394    18284     -110     
==========================================
+ Hits        17375    17473      +98     
+ Misses        876      651     -225     
- Partials      143      160      +17     
Flag Coverage Δ
cassandra-3.x 25.58% <ø> (?)
cassandra-4.x 25.58% <ø> (?)
elasticsearch-5.x 19.87% <ø> (?)
elasticsearch-6.x 19.87% <ø> (ø)
elasticsearch-7.x 19.99% <ø> (-0.02%) ⬇️
elasticsearch-8.x 20.09% <ø> (ø)
grpc-badger 19.51% <ø> (+<0.01%) ⬆️
kafka 14.09% <ø> (?)
opensearch-1.x 20.00% <ø> (?)
opensearch-2.x 19.99% <ø> (?)
unittests 93.22% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit acf36f4 into jaegertracing:main Jan 16, 2024
40 of 41 checks passed
@yurishkuro yurishkuro deleted the remove-jaeger-otlp branch January 16, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:breaking-change Change that is breaking public APIs or established behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants