Replace goleak.VerifyTestMain with testutils.VerifyGoLeaks #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5108 +/- ##
==========================================
- Coverage 95.59% 95.56% -0.04%
==========================================
Files 317 317
Lines 18284 18284
==========================================
- Hits 17479 17473 -6
- Misses 647 651 +4
- Partials 158 160 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Jan 16, 2024
pkg/gogocodec/codec_test.go
Outdated
| @@ -11,7 +11,6 @@ | |||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
There was a problem hiding this comment.
what's with the changes in this file?
There was a problem hiding this comment.
I was resolving conflicts but forgot that I needed to remove this change.
yurishkuro
reviewed
Jan 16, 2024
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
yurishkuro
reviewed
Jan 16, 2024
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
yurishkuro
reviewed
Jan 16, 2024
pkg/gogocodec/codec_test.go
Outdated
| s2 := &model.Span{} | ||
|
|
There was a problem hiding this comment.
Because while I was doing these changes, I was two commits behind the main. I was manually resolving conflicts by comparing changes. But by mistake, I might have forgotten.
removing it now
yurishkuro
changed the title
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
yurishkuro
added
the
changelog:test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
testutils.VerifyGoLeaksas satisfactory.goleak.VerifyTestMainwithtestutils.VerifyGoLeaks.How was this change tested?
make testChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test