Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid changing a correct order of span references #5121

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

sherwoodwang
Copy link
Contributor

@sherwoodwang sherwoodwang commented Jan 19, 2024

Which problem is this PR solving?

Description of the changes

  • Avoid changing order in the case described above.

How was this change tested?

  • A test case is added.

Checklist

@yurishkuro
Copy link
Member

please use descriptive PR title

@sherwoodwang sherwoodwang changed the title Patch 1 Avoid changing order of span references when it's correct Jan 19, 2024
@sherwoodwang sherwoodwang changed the title Avoid changing order of span references when it's correct Avoid changing the order of span references when it's correct Jan 19, 2024
@sherwoodwang sherwoodwang changed the title Avoid changing the order of span references when it's correct Avoid changing a correct order of span references Jan 19, 2024
@sherwoodwang
Copy link
Contributor Author

please use descriptive PR title

done

…place

Signed-off-by: Sherwood Wang <sherwoodwang@users.noreply.github.com>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable, thanks

Copy link

Test Results

2 076 tests  +1   2 066 ✅ +1   1m 9s ⏱️ ±0s
  216 suites ±0      10 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 8682066. ± Comparison against base commit 88efe47.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88efe47) 95.62% compared to head (8682066) 95.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5121      +/-   ##
==========================================
- Coverage   95.62%   95.60%   -0.03%     
==========================================
  Files         322      322              
  Lines       18454    18454              
==========================================
- Hits        17647    17643       -4     
- Misses        649      651       +2     
- Partials      158      160       +2     
Flag Coverage Δ
cassandra-3.x 25.58% <0.00%> (ø)
cassandra-4.x 25.58% <0.00%> (ø)
elasticsearch-5.x 19.87% <0.00%> (ø)
elasticsearch-6.x 19.87% <0.00%> (ø)
elasticsearch-7.x 20.00% <0.00%> (ø)
elasticsearch-8.x 20.08% <0.00%> (-0.02%) ⬇️
grpc-badger 19.51% <0.00%> (ø)
kafka 14.09% <0.00%> (ø)
opensearch-1.x 19.99% <0.00%> (ø)
opensearch-2.x 20.00% <0.00%> (ø)
unittests 93.29% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro enabled auto-merge (squash) January 19, 2024 17:41
@yurishkuro yurishkuro merged commit adbdb2d into jaegertracing:main Jan 19, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The CHILD_OF span reference is moved to the second place incorrectly
2 participants