Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Adaptive sampling support for Elasticsearch #5169

Closed

Conversation

Wise-Wizard
Copy link
Contributor

Which problem is this PR solving?

This PR addresses a part of the issue #5084 which is Storage backends for adaptive sampling #3305.

Description of the changes

This PR introduces the integration of adaptive sampling with Elasticsearch, as part of the ongoing effort to support storage backends for adaptive sampling. The changes include the implementation of key functions and structures necessary for seamless integration.

How was this change tested?

Tests for this change are yet to be added. The subsequent commits will include comprehensive unit tests to validate the functionality.

Checklist

  • I have read CONTRIBUTING_GUIDELINES.md
  • I have signed all commits
  • I have added unit tests for the new functionality
  • I have run lint and test steps successfully
    • for jaeger: make lint test
    • for jaeger-ui: yarn lint and yarn test

Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
@Wise-Wizard Wise-Wizard requested a review from a team as a code owner February 6, 2024 14:38
@Wise-Wizard
Copy link
Contributor Author

Hi @yurishkuro,
Could you please review the current approach and let me know if it aligns with the project's goals? Any feedback or guidance would be immensely helpful.
Thanks!

@yurishkuro
Copy link
Member

Resolved in #5158

@yurishkuro yurishkuro closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants