Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HotROD instructions #5273

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Mar 14, 2024

Which problem is this PR solving?

  • The README was showing a command with the legacy OTEL_EXPORTER_JAEGER_ENDPOINT env var (using Jaeger format)

Description of the changes

  • Change to use OTEL_EXPORTER_OTLP_ENDPOINT to match the docker-compose setup.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner March 14, 2024 04:20
@yurishkuro yurishkuro added the changelog:breaking-change Change that is breaking public APIs or established behavior label Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (ccecb7f) to head (402bec7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5273      +/-   ##
==========================================
+ Coverage   95.09%   95.10%   +0.01%     
==========================================
  Files         339      339              
  Lines       16511    16511              
==========================================
+ Hits        15701    15703       +2     
+ Misses        621      620       -1     
+ Partials      189      188       -1     
Flag Coverage Δ
cassandra-3.x 26.53% <ø> (ø)
cassandra-4.x 26.53% <ø> (ø)
elasticsearch-5.x 21.77% <ø> (ø)
elasticsearch-6.x 21.77% <ø> (+0.01%) ⬆️
elasticsearch-7.x 21.85% <ø> (ø)
elasticsearch-8.x 21.92% <ø> (-0.02%) ⬇️
grpc-badger 19.23% <ø> (ø)
kafka 14.66% <ø> (ø)
opensearch-1.x 21.84% <ø> (ø)
opensearch-2.x 21.84% <ø> (-0.02%) ⬇️
unittests 92.72% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit c78cbdb into jaegertracing:main Mar 14, 2024
36 checks passed
@yurishkuro yurishkuro deleted the fix-hotrod-readme branch March 14, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:breaking-change Change that is breaking public APIs or established behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants