Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor healthcheck signalling between server and service #5308

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Refactor healthcheck signalling between server and service #5308

merged 2 commits into from
Mar 28, 2024

Commits on Mar 28, 2024

  1. Refactor healthcheck signalling between server and service 

    Simplifies the signalling of healthcheck status from the "servers"
to the "service": instead of using 2 channels to feed healthcheck
status back to the Service.HealthCheck, we just give the server
components direct access to the Healthcheck which they can update
directly. This is possible because the Healthcheck package is
threadsafe (uses `atomic.Value` for state).

This pattern is consisten with how the service's Healtcheck is
passed directly to cmd/collector/app package.

closes jaegertracing#5307

Signed-off-by: Will Sewell <willsewell@monzo.com>
    @WillSewell
    WillSewell committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    df0ad22 View commit details
    Browse the repository at this point in the history

  2. add TODO 

    Signed-off-by: Yuri Shkuro <github@ysh.us>
    @yurishkuro
    yurishkuro committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    0c5307e View commit details
    Browse the repository at this point in the history