[jaeger-v2] add elasticsearch & opensearch e2e integration test #5345

Pushkarm029 · 2024-04-10T11:44:46Z

Which problem is this PR solving?

part of [jaeger-v2] Storage backend integration tests #5254

Description of the changes

Utilizing existing StorageIntegration to test the jaeger-v2 OTel Collector and gRPC storage backend with the provided config file at cmd/jaeger/config-elasticsearch.yaml.

How was this change tested?

Start a elasticsearch or opensearch docker instance.
Run STORAGE=elasticsearch SPAN_STORAGE_TYPE=elasticsearch make jaeger-v2-storage-integration-test

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: yarn lint and yarn test

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

Pushkarm029 · 2024-04-10T12:02:23Z

Currently, the Traces are stored correctly in the database but the test is not able to read from it.

ElasticSearch logs

{"took":768,"timed_out":false,"_shards":{"total":1,"successful":1,"skipped":0,"failed":0},"hits":{"total":{"value":1105,"relation":"eq"},"max_score":1.0,"hits":[{"_index":"jaeger-main-jaeger-span-write","_type":"_doc","_id":"NBW1x44Bj8WH9-LVviap","_score":1.0,"_source":{"traceID":"0000000000000512","spanID":"0000000000000005","operationName":"query23-operation","references":[],"startTime":1712681191639875,"startTimeMillis":1712681191639,"duration":1,"tags":[{"key":"sameplacetag1","type":"string","value":"same*"}],"logs":[{"timestamp":1712681191639875,"fields":null},{"timestamp":1712681191639875,"fields":null}],"process":{"serviceName":"query23-service","tags":[]}}},{"_index":"jaeger-main-jaeger-span-write","_type":"_doc","_id":"NRW1x44Bj8WH9-LVvib_","_score":1.0,"_source":{"traceID":"0000000000000a12","spanID":"0000000000000004","operationName":"","references":[],"startTime":1712681191639875,"startTimeMillis":1712681191639,"duration":2,"tags":[{"key":"sameplacetag1","type":"string","value":"sameplacevalue1"}],"logs":[],"process":{"serviceName":"query24-service","tags":[]}}},{"_index":"jaeger-main-jaeger-span-write","_type":"_doc","_id":"NhW1x44Bj8WH9-LVvyYJ","_score":1.0,"_source":{"traceID":"0000000000001212","spanID":"0000000000000004","operationName":"","references":[],"startTime":1712681191639875,"startTimeMillis":1712681191639,"duration":2,"tags":[{"key":"sameplacetag1","type":"string","value":"sameplacevalue2"}],"logs":[],"process":{"serviceName":"query24-service","tags":[]}}},{"_index":"jaeger-main-jaeger-span-write","_type":"_doc","_id":"NxW1x44Bj8WH9-LVvyYi","_score":1.0,"_source":{"traceID":"0000000000000001","spanID":"0000000000000002","operationName":"some-operation","references":[],"startTime":1712681191639875,"startTimeMillis":1712681191639,"duration":7,"tags":[{"key":"sameplacetag1","type":"string","value":"sameplacevalue"},{"key":"sameplacetag2","type":"int64","value":"123"},{"key":"sameplacetag4","type":"bool","value":"true"},{"key":"sameplacetag3","type":"float64","value":"72.5"}]

Error in test

github.com/jaegertracing/jaeger/cmd/query/app.(*GRPCHandler).GetTrace
        /home/pushkar/jaeger/cmd/query/app/grpc_handler.go:105
github.com/jaegertracing/jaeger/proto-gen/api_v2._QueryService_GetTrace_Handler
        /home/pushkar/jaeger/proto-gen/api_v2/query.pb.go:1009
google.golang.org/grpc.(*Server).processStreamingRPC
        /home/pushkar/jaeger/vendor/google.golang.org/grpc/server.go:1663
google.golang.org/grpc.(*Server).handleStream
        /home/pushkar/jaeger/vendor/google.golang.org/grpc/server.go:1784
google.golang.org/grpc.(*Server).serveStreams.func2.1
        /home/pushkar/jaeger/vendor/google.golang.org/grpc/server.go:1019
    integration.go:276: trace not found
    integration.go:143: Waiting for storage backend to update documents, iteration 2 out of 100
2024-04-10T17:30:57.541+0530    error   app/grpc_handler.go:105 trace not found {"kind": "extension", "name": "jaeger_query", "error": "trace not found"}

yurishkuro · 2024-04-10T13:37:39Z

Do you have a plan how to solve it?

cmd/jaeger/config-elasticsearch.yaml

cmd/jaeger/internal/integration/es_test.go

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

Pushkarm029 · 2024-04-11T18:14:49Z

Do you have a plan for how to solve it?

At first, I thought there might be some error in the rpc connection between the query and elastic search storage. After investigating, I learned the problem is in receiving spans from the stream (cmd/jaeger/internal/integration/span_reader.go:L78). because the requested operation, for e.g. GetTrace, is getting stored in elasticsearch storage (see this JSON).

As we know, in another test (e.g., grpc_test) for some early iterations, we get a similar error, and after that, we get our spans. But here, even after increasing it to 1000, it's not working.

Currently, I have zero clues, but I am trying to figure out how to solve it.

yurishkuro · 2024-04-11T18:41:51Z

The ES client has a TraceLogger, which we do not initialize today. I suggest implementing some flag somewhere that would initialize this logger to be able to see which queries ES Storage is making to the ES Backend (this would be a separate PR).

Pushkarm029 · 2024-04-12T15:03:16Z

do we need something like this?

{"level":"info","ts":1712921641.4783256,"caller":"zapgrpc/zapgrpc.go:128","msg":"HTTP/1.1 200 OK\r\nContent-Type: application/json; charset=UTF-8\r\nX-Elastic-Product: Elasticsearch\r\n\r\n{\"took\":12,\"errors\":false,\"items\":[{\"index\":{\"_index\":\"jaeger-main-jaeger-service-write\",\"_type\":\"_doc\",\"_id\":\"5c78c55a6b1b86a1\",\"_version\":1,\"result\":\"created\",\"_shards\":{\"total\":2,\"successful\":1,\"failed\":0},\"_seq_no\":3,\"_primary_term\":1,\"status\":201}}]}\n"}
{"level":"info","ts":1712921641.4787142,"caller":"zapgrpc/zapgrpc.go:128","msg":"POST /_bulk HTTP/1.1\r\nHost: localhost:9200\r\nUser-Agent: elastic/6.2.37 (linux-amd64)\r\nContent-Length: 459\r\nAccept: application/json\r\nContent-Type: application/x-ndjson\r\nAccept-Encoding: gzip\r\n\r\n{\"index\":{\"_index\":\"jaeger-main-jaeger-span-write\"}}\n{\"traceID\":\"0000000000000011\",\"spanID\":\"0000000000000006\",\"operationName\":\"example-operation-3\",\"references\":[],\"startTime\":1712853991639875,\"startTimeMillis\":1712853991639,\"duration\":100,\"tags\":[{\"key\":\"span.kind\",\"type\":\"string\",\"value\":\"server\"}],\"logs\":[{\"timestamp\":1712853991639875,\"fields\":null},{\"timestamp\":1712853991639875,\"fields\":null}],\"process\":{\"serviceName\":\"example-service-1\",\"tags\":[]}}\n\n"}

    integration.go:276: trace not found

{"level":"info","ts":1712921641.5270474,"caller":"zapgrpc/zapgrpc.go:128","msg":"GET /_msearch?rest_total_hits_as_int=true HTTP/1.1\r\nHost: localhost:9200\r\nUser-Agent: elastic/6.2.37 (linux-amd64)\r\nContent-Length: 403\r\nAccept: application/json\r\nContent-Type: application/json\r\nAccept-Encoding: gzip\r\n\r\n{\"ignore_unavailable\":true,\"index\":\"jaeger-main-jaeger-span-read\"}\n{\"query\":{\"bool\":{\"must\":[{\"bool\":{\"should\":[{\"term\":{\"traceID\":{\"boost\":2,\"value\":\"0000000000000011\"}}},{\"term\":{\"traceID\":\"11\"}}]}},{\"range\":{\"startTimeMillis\":{\"from\":136035241526,\"include_lower\":true,\"include_upper\":true,\"to\":1713008041526}}}]}},\"search_after\":[136118041526656],\"size\":10000,\"sort\":[{\"startTime\":{\"order\":\"asc\"}}]}\n\n"}
{"level":"info","ts":1712921641.5347877,"caller":"zapgrpc/zapgrpc.go:128","msg":"HTTP/1.1 200 OK\r\nContent-Type: application/json; charset=UTF-8\r\nX-Elastic-Product: Elasticsearch\r\n\r\n{\"took\":0,\"responses\":[{\"took\":0,\"timed_out\":false,\"_shards\":{\"total\":0,\"successful\":0,\"skipped\":0,\"failed\":0},\"hits\":{\"total\":0,\"max_score\":0.0,\"hits\":[]},\"status\":200}]}\n"}
2024-04-12T17:04:01.534+0530	error	app/grpc_handler.go:105	trace not found	{"kind": "extension", "name": "jaeger_query", "error": "trace not found"}

here, in log, we can see the client is trying to perform get query in jaeger-main-jaeger-span-read index. but actually, it doesn't exists in elasticsearch.

health status index                            uuid                   pri rep docs.count docs.deleted store.size pri.store.size
green  open   .geoip_databases                 0z0sUHE3TaedeUallyGkMA   1   0         35            0     32.4mb         32.4mb
yellow open   jaeger-main-jaeger-span-write    2AEUrJFkSEKX9SWzgv8wKg   1   1         63            0      152kb          152kb
yellow open   jaeger-main-jaeger-service-write m8pO7MKwSXuOgtv9R5Tvlw   1   1          7            0     13.8kb         13.8kb```

yurishkuro · 2024-04-12T16:06:39Z

do we need something like this?

Yes! Can you make a PR to support an option to turn this on?

here, in log, we can see the client is trying to perform get query in jaeger-main-jaeger-span-read index. but actually, it doesn't exists in elasticsearch.

Yep, this seems to be the root cause. Why doesn't it exist? When using read/write name it sounds like the aliasing solution with ILM enabled, maybe it's incorrectly enabled for the tests?

Pushkarm029 · 2024-04-12T19:52:47Z

Yes! Can you make a PR to support an option to turn this on?

Yes, I can add it. But I see; we can already enable this by setting log_level to debug. But if we still need it, we can create another option in config.

Yep, this seems to be the root cause. Why doesn't it exist? When using read/write name it sounds like the aliasing solution with ILM enabled, maybe it's incorrectly enabled for the tests?

will take look into it.

yurishkuro · 2024-04-12T23:10:48Z

If it's already can be enabled via existing flags then don't change it

Pushkarm029 · 2024-04-13T18:26:42Z

one more interesting finding:
if we enable useilm for v1 integration, we can see similar results (jaeger-read index didn't exists & test fails).

Pushkarm029 · 2024-04-13T21:48:52Z

made some progress :

--- ❌ FAIL: TestESStorage (202.01s)
    --- ✅ PASS: TestESStorage/GetServices (2.71s)
    --- ❌ FAIL: TestESStorage/GetOperations (101.32s)
    --- ✅ PASS: TestESStorage/GetTrace (3.27s)
        --- ✅ PASS: TestESStorage/GetTrace/NotFound_error (0.01s)
    --- ✅ PASS: TestESStorage/GetLargeSpans (89.15s)
    --- ✅ FAIL: TestESStorage/FindTraces (4.44s)
        --- ✅ FAIL: TestESStorage/FindTraces/Tag_escaped_operator_+_Operation_name_+_max_Duration (1.53s)
        --- ✅ FAIL: TestESStorage/FindTraces/Tag_wildcard_regex (0.03s)
        --- ✅ FAIL: TestESStorage/FindTraces/Tags_in_one_spot_-_Tags (0.02s)
        --- ✅ FAIL: TestESStorage/FindTraces/Tags_in_one_spot_-_Logs (0.03s)
        --- ✅ PASS: TestESStorage/FindTraces/Tags_in_one_spot_-_Process (1.64s)
        --- ✅ PASS: TestESStorage/FindTraces/Tags_in_different_spots (0.06s)
        --- ✅ PASS: TestESStorage/FindTraces/Trace_spans_over_multiple_indices (0.05s)
        --- ✅ PASS: TestESStorage/FindTraces/Operation_name (0.03s)
        --- ✅ PASS: TestESStorage/FindTraces/Operation_name_+_max_Duration (0.05s)
        --- ✅ PASS: TestESStorage/FindTraces/Operation_name_+_Duration_range (0.04s)
        --- ✅ PASS: TestESStorage/FindTraces/Duration_range (0.02s)
        --- ✅ PASS: TestESStorage/FindTraces/max_Duration (0.04s)
        --- ✅ PASS: TestESStorage/FindTraces/default (0.02s)
        --- ✅ PASS: TestESStorage/FindTraces/Tags_+_Operation_name (0.05s)
        --- ✅ PASS: TestESStorage/FindTraces/Tags_+_Operation_name_+_max_Duration (0.04s)
        --- ✅ PASS: TestESStorage/FindTraces/Tags_+_Operation_name_+_Duration_range (0.03s)
        --- ✅ PASS: TestESStorage/FindTraces/Tags_+_Duration_range (0.06s)
        --- ✅ PASS: TestESStorage/FindTraces/Tags_+_max_Duration (0.12s)
        --- ✅ PASS: TestESStorage/FindTraces/Multi-spot_Tags_+_Operation_name (0.03s)
        --- ✅ PASS: TestESStorage/FindTraces/Multi-spot_Tags_+_Operation_name_+_max_Duration (0.05s)
        --- ✅ PASS: TestESStorage/FindTraces/Multi-spot_Tags_+_Operation_name_+_Duration_range (0.04s)
        --- ✅ PASS: TestESStorage/FindTraces/Multi-spot_Tags_+_Duration_range (0.03s)
        --- ✅ PASS: TestESStorage/FindTraces/Multi-spot_Tags_+_max_Duration (0.03s)
        --- ✅ PASS: TestESStorage/FindTraces/Multiple_Traces (0.02s)

Pushkarm029 · 2024-04-14T15:35:15Z

@james-ryans getting same issue here also

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

plugin/storage/es/factory.go

plugin/storage/es/options.go

plugin/storage/integration/elasticsearch_client.go

plugin/storage/integration/elasticsearch_test.go

scripts/grpc-integration-test.sh

cmd/jaeger/internal/integration/es_test.go

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

plugin/storage/integration/elasticsearch_test.go

Pushkarm029 · 2024-04-17T17:57:37Z

--- ❌ FAIL: TestESStorage (202.01s)
--- ✅ PASS: TestESStorage/GetServices (2.71s)
--- ❌ FAIL: TestESStorage/GetOperations (101.32s)
--- ✅ PASS: TestESStorage/GetTrace (3.27s)
--- ✅ PASS: TestESStorage/GetLargeSpans (89.15s)
--- ✅ FAIL: TestESStorage/FindTraces (4.44s)

still not able to fix this.
when i run services and operation test indiviually, they both pass. but together, the one which is kept second always fail.

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

yurishkuro · 2024-04-18T14:56:50Z

when i run services and operation test indiviually, they both pass. but together, the one which is kept second always fail.

that sounds like you either have data pollution across tests, or the opposite - a dependency of one test on another's input data (although in that case tests would not succeed individually).

james-ryans · 2024-04-18T15:09:14Z

--- ❌ FAIL: TestESStorage (202.01s)
--- ✅ PASS: TestESStorage/GetServices (2.71s)
--- ❌ FAIL: TestESStorage/GetOperations (101.32s)
--- ✅ PASS: TestESStorage/GetTrace (3.27s)
--- ✅ PASS: TestESStorage/GetLargeSpans (89.15s)
--- ✅ FAIL: TestESStorage/FindTraces (4.44s)

still not able to fix this. when i run services and operation test indiviually, they both pass. but together, the one which is kept second always fail.

This might be interesting to find out. I still cannot find which line of code outputs this.

...
=== RUN   TestESStorage/GetOperations
    integration.go:364: Dropped binary type attributes from trace ID: 0000000000000011
    integration.go:134: Waiting for storage backend to update documents, iteration 1 out of 100
    integration.go:134: Waiting for storage backend to update documents, iteration 2 out of 100
    integration.go:134: Waiting for storage backend to update documents, iteration 3 out of 100
    integration.go:134: Waiting for storage backend to update documents, iteration 4 out of 100
    integration.go:134: Waiting for storage backend to update documents, iteration 5 out of 100
    integration.go:134: Waiting for storage backend to update documents, iteration 6 out of 100
    integration.go:134: Waiting for storage backend to update documents, iteration 7 out of 100
    integration.go:134: Waiting for storage backend to update documents, iteration 8 out of 100
    integration.go:134: Waiting for storage backend to update documents, iteration 9 out of 100
    integration.go:134: Waiting for storage backend to update documents, iteration 10 out of 100
    integration.go:134: Waiting for storage backend to update documents, iteration 11 out of 100
    integration.go:134: Waiting for storage backend to update documents, iteration 12 out of 100
2024/04/17 18:16:49 traces export: context deadline exceeded: rpc error: code = DeadlineExceeded desc = context deadline exceeded
    integration.go:134: Waiting for storage backend to update documents, iteration 13 out of 100
    ...

yurishkuro · 2024-04-18T15:21:23Z

@james-ryans which line are you referring to?

Pushkarm029 · 2024-04-18T15:28:45Z

This might be interesting to find out. I still cannot find which line of code outputs this.

2024/04/17 18:16:49 traces export: context deadline exceeded: rpc error: code = DeadlineExceeded desc = context deadline exceeded

This happens sometimes, please try to run the test again.

cmd/jaeger/internal/integration/es_test.go

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

Pushkarm029 · 2024-04-29T14:55:19Z

i am not able to clear cache yet.

scripts/es-integration-test.sh

Makefile

cmd/jaeger/internal/integration/es_test.go

pkg/cache/lru.go

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

cmd/jaeger/internal/integration/integration.go

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

codecov · 2024-04-30T11:16:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (75067c5) to head (add0134).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5345      +/-   ##
==========================================
- Coverage   95.19%   94.55%   -0.65%     
==========================================
  Files         346      346              
  Lines       16916    16945      +29     
==========================================
- Hits        16104    16022      -82     
- Misses        610      722     +112     
+ Partials      202      201       -1

Flag	Coverage Δ
badger_v1	`10.29% <0.00%> (-0.01%)`	⬇️
badger_v2	`6.54% <26.66%> (+0.13%)`	⬆️
cassandra-3.x	`18.14% <0.00%> (-0.01%)`	⬇️
cassandra-4.x	`18.14% <0.00%> (-0.01%)`	⬇️
elasticsearch-5.x	`5.89% <35.00%> (-15.14%)`	⬇️
elasticsearch-6.x	`5.91% <35.00%> (-15.12%)`	⬇️
elasticsearch-7.x	`5.89% <35.00%> (-15.18%)`	⬇️
elasticsearch-8.x	`5.91% <35.00%> (-15.37%)`	⬇️
grpc_v1	`12.60% <0.00%> (-0.01%)`	⬇️
grpc_v2	`11.52% <11.66%> (-0.01%)`	⬇️
kafka	`9.96% <0.00%> (-0.01%)`	⬇️
opensearch-1.x	`5.91% <35.00%> (-15.22%)`	⬇️
opensearch-2.x	`5.89% <35.00%> (-15.24%)`	⬇️
unittests	`91.35% <53.33%> (-0.13%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

## Which problem is this PR solving? - part of #5345 ## Description of the changes - Added Purge method for ES/OS - optimized integration test for es/os storage ## How was this change tested? - `STORAGE=elasticsearch make storage-integration-test` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

cmd/jaeger/internal/integration/es_test.go

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

yurishkuro

🎉

## Which problem is this PR solving? - part of jaegertracing#5345 ## Description of the changes - Added Purge method for ES/OS - optimized integration test for es/os storage ## How was this change tested? - `STORAGE=elasticsearch make storage-integration-test` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

…ertracing#5345) ## Which problem is this PR solving? - part of jaegertracing#5254 ## Description of the changes - Utilizing existing `StorageIntegration` to test the jaeger-v2 OTel Collector and gRPC storage backend with the provided config file at `cmd/jaeger/config-elasticsearch.yaml`. ## How was this change tested? - Start a elasticsearch or opensearch docker instance. - Run `STORAGE=elasticsearch SPAN_STORAGE_TYPE=elasticsearch make jaeger-v2-storage-integration-test` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

Add ES E2E Test

6a6f31d

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

yurishkuro reviewed Apr 10, 2024

View reviewed changes

cmd/jaeger/config-elasticsearch.yaml Show resolved Hide resolved

cmd/jaeger/internal/integration/es_test.go Outdated Show resolved Hide resolved

refactor done

4f30164

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

fix

1b01f79

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Apr 14, 2024

yurishkuro reviewed Apr 14, 2024

View reviewed changes

Pushkarm029 added 2 commits April 16, 2024 00:51

Merge branch 'main' into es_e2e

b3bfe05

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

refactor

3f00999

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

Pushkarm029 commented Apr 17, 2024

View reviewed changes

plugin/storage/integration/elasticsearch_test.go Outdated Show resolved Hide resolved

Pushkarm029 added 5 commits April 17, 2024 23:31

added grpc int test script again

4c7ece8

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

fix perm

483f0d1

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

Merge branch 'main' into es_e2e

223781d

fix

83e7c13

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

fix

adee66e

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

yurishkuro reviewed Apr 26, 2024

View reviewed changes

cmd/jaeger/internal/integration/es_test.go Outdated Show resolved Hide resolved

cmd/jaeger/internal/integration/es_test.go Outdated Show resolved Hide resolved

cmd/jaeger/internal/integration/es_test.go Outdated Show resolved Hide resolved

Pushkarm029 added 2 commits April 29, 2024 11:40

Merge branch 'main' into es_e2e

784b0d8

fix

d48d7e6

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

yurishkuro reviewed Apr 30, 2024

View reviewed changes

scripts/es-integration-test.sh Show resolved Hide resolved

yurishkuro reviewed Apr 30, 2024

View reviewed changes

Makefile Outdated Show resolved Hide resolved

yurishkuro reviewed Apr 30, 2024

View reviewed changes

cmd/jaeger/internal/integration/es_test.go Show resolved Hide resolved

yurishkuro reviewed Apr 30, 2024

View reviewed changes

pkg/cache/lru.go Outdated Show resolved Hide resolved

fix

51e0594

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

Pushkarm029 commented Apr 30, 2024

View reviewed changes

cmd/jaeger/internal/integration/integration.go Outdated Show resolved Hide resolved

Pushkarm029 added 2 commits April 30, 2024 16:20

fix

58eee58

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

Merge branch 'main' into es_e2e

78e968c

Pushkarm029 marked this pull request as ready for review April 30, 2024 11:01

Pushkarm029 requested a review from a team as a code owner April 30, 2024 11:01

Pushkarm029 requested a review from albertteoh April 30, 2024 11:01

Pushkarm029 mentioned this pull request May 2, 2024

Add Purge method for ES/OS #5407

Merged

4 tasks

Pushkarm029 added 3 commits May 3, 2024 18:21

removed cachePurge

d6ab071

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

Merge branch 'main' into es_e2e

7d1ecd2

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

fix

b706584

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

yurishkuro reviewed May 3, 2024

View reviewed changes

cmd/jaeger/internal/integration/es_test.go Outdated Show resolved Hide resolved

Pushkarm029 added 2 commits May 3, 2024 19:39

fix

fe34da5

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>

Merge branch 'main' into es_e2e

add0134

yurishkuro approved these changes May 3, 2024

View reviewed changes

yurishkuro merged commit f1d95f9 into jaegertracing:main May 3, 2024
38 checks passed

yurishkuro mentioned this pull request May 3, 2024

[jaeger-v2] Storage backend integration tests #5254

Closed

5 tasks

Pushkarm029 deleted the es_e2e branch May 3, 2024 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[jaeger-v2] add elasticsearch & opensearch e2e integration test #5345

[jaeger-v2] add elasticsearch & opensearch e2e integration test #5345

Pushkarm029 commented Apr 10, 2024

Pushkarm029 commented Apr 10, 2024 •

edited

Loading

yurishkuro commented Apr 10, 2024

Pushkarm029 commented Apr 11, 2024

yurishkuro commented Apr 11, 2024

Pushkarm029 commented Apr 12, 2024

yurishkuro commented Apr 12, 2024

Pushkarm029 commented Apr 12, 2024

yurishkuro commented Apr 12, 2024

Pushkarm029 commented Apr 13, 2024

Pushkarm029 commented Apr 13, 2024 •

edited

Loading

Pushkarm029 commented Apr 14, 2024

Pushkarm029 commented Apr 17, 2024

yurishkuro commented Apr 18, 2024

james-ryans commented Apr 18, 2024

yurishkuro commented Apr 18, 2024

Pushkarm029 commented Apr 18, 2024 •

edited

Loading

Pushkarm029 commented Apr 29, 2024

codecov bot commented Apr 30, 2024 •

edited

Loading

yurishkuro left a comment

[jaeger-v2] add elasticsearch & opensearch e2e integration test #5345

[jaeger-v2] add elasticsearch & opensearch e2e integration test #5345

Conversation

Pushkarm029 commented Apr 10, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Pushkarm029 commented Apr 10, 2024 • edited Loading

ElasticSearch logs

Error in test

yurishkuro commented Apr 10, 2024

Pushkarm029 commented Apr 11, 2024

yurishkuro commented Apr 11, 2024

Pushkarm029 commented Apr 12, 2024

yurishkuro commented Apr 12, 2024

Pushkarm029 commented Apr 12, 2024

yurishkuro commented Apr 12, 2024

Pushkarm029 commented Apr 13, 2024

Pushkarm029 commented Apr 13, 2024 • edited Loading

Pushkarm029 commented Apr 14, 2024

Pushkarm029 commented Apr 17, 2024

yurishkuro commented Apr 18, 2024

james-ryans commented Apr 18, 2024

yurishkuro commented Apr 18, 2024

Pushkarm029 commented Apr 18, 2024 • edited Loading

Pushkarm029 commented Apr 29, 2024

codecov bot commented Apr 30, 2024 • edited Loading

Codecov Report

yurishkuro left a comment

Choose a reason for hiding this comment

Pushkarm029 commented Apr 10, 2024 •

edited

Loading

Pushkarm029 commented Apr 13, 2024 •

edited

Loading

Pushkarm029 commented Apr 18, 2024 •

edited

Loading

codecov bot commented Apr 30, 2024 •

edited

Loading