Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update security files and other governance files for best practices #5365

Merged
merged 5 commits into from
Apr 16, 2024

Conversation

jkowall
Copy link
Contributor

@jkowall jkowall commented Apr 16, 2024

Only changes in md for this one

Adding MAINTAINERS.md, and fixing a 404 in GOVERNANCE.md
Fixing CODE_OF_CONDUCT per template : https://github.com/cncf/project-template/blob/main/CODE_OF_CONDUCT.md

Working on : #5363

Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

They can merge their own patches or patches from others. The current maintainers can be found in [CODEOWNERS](./CODEOWNERS).
They can merge their own patches or patches from others. The current maintainers can be found in [MAINTAINERS](./MAINTAINERS.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pickup.

MAINTAINERS.md Outdated Show resolved Hide resolved

| Name | Employer | Responsibilities |
| ---- | -------- | ---------------- |
| [@albertteoh](https://github.com/albertteoh) | PackSmith | All |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other ALLs are upper-case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you want to fix this? ^

@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Apr 16, 2024
jkowall and others added 2 commits April 16, 2024 19:13
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (9073fe3) to head (7bd276a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5365   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files         343      343           
  Lines       16777    16777           
=======================================
  Hits        15974    15974           
  Misses        605      605           
  Partials      198      198           
Flag Coverage Δ
badger 10.50% <ø> (ø)
cassandra-3.x 18.43% <ø> (ø)
cassandra-4.x 18.43% <ø> (ø)
elasticsearch-5.x 20.89% <ø> (ø)
elasticsearch-6.x 20.88% <ø> (ø)
elasticsearch-7.x 20.94% <ø> (ø)
elasticsearch-8.x 21.12% <ø> (ø)
grpc 14.60% <ø> (ø)
kafka 10.17% <ø> (ø)
opensearch-1.x 20.99% <ø> (+0.01%) ⬆️
opensearch-2.x 20.98% <ø> (-0.02%) ⬇️
unittests 91.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkowall jkowall merged commit f12d420 into jaegertracing:main Apr 16, 2024
37 checks passed
@jkowall jkowall deleted the update-security-files branch April 17, 2024 14:30
varshith257 pushed a commit to varshith257/jaeger that referenced this pull request May 3, 2024
…aegertracing#5365)

Only changes in md for this one

Adding MAINTAINERS.md, and fixing a 404 in GOVERNANCE.md
Fixing CODE_OF_CONDUCT per template :
https://github.com/cncf/project-template/blob/main/CODE_OF_CONDUCT.md

Working on : jaegertracing#5363

---------

Signed-off-by: Jonah Kowall <jkowall@kowall.net>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants