Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build Docker images for Crossdock tests for linux/amd64 #5410

Merged
merged 4 commits into from
May 3, 2024

Conversation

varshith257
Copy link
Contributor

@varshith257 varshith257 commented May 3, 2024

Which problem is this PR solving?

Description of the changes

  • Added the logic same in the docker-image CI to build linux/amd64 architecture only

How was this change tested?

  • Not yet

Checklist

Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
@varshith257 varshith257 requested a review from a team as a code owner May 3, 2024 06:24
@varshith257 varshith257 requested a review from jkowall May 3, 2024 06:24
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (4092dec) to head (68c370f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5410      +/-   ##
==========================================
+ Coverage   95.19%   95.21%   +0.01%     
==========================================
  Files         346      346              
  Lines       16916    16916              
==========================================
+ Hits        16104    16106       +2     
+ Misses        610      609       -1     
+ Partials      202      201       -1     
Flag Coverage Δ
badger_v1 10.30% <ø> (ø)
badger_v2 6.41% <ø> (?)
cassandra-3.x 18.15% <ø> (ø)
cassandra-4.x 18.15% <ø> (ø)
elasticsearch-5.x 21.03% <ø> (ø)
elasticsearch-6.x 21.01% <ø> (ø)
elasticsearch-7.x 21.08% <ø> (ø)
elasticsearch-8.x 21.27% <ø> (+0.01%) ⬆️
grpc_v1 12.63% <ø> (+0.02%) ⬆️
grpc_v2 11.53% <ø> (ø)
kafka 9.97% <ø> (ø)
opensearch-1.x 21.12% <ø> (-0.02%) ⬇️
opensearch-2.x 21.12% <ø> (-0.02%) ⬇️
unittests 91.48% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varshith257
Copy link
Contributor Author

@yurishkuro PTAL

	docker buildx build --target release \
		--tag jaegertracing/$component:latest \
		--build-arg base_image=localhost:5000/baseimg_alpine:latest \
		--build-arg debug_image=localhost:5000/debugimg_alpine:latest \
		--build-arg TARGETARCH=amd64 \

@yurishkuro yurishkuro changed the title Updated Crossdock tests to build Docker images for linux/amd64 only Only build Docker images for Crossdock tests for linux/amd64 May 3, 2024
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label May 3, 2024
@yurishkuro
Copy link
Member

Great, I am not seeing other arches in the logs, and the step run time went down from 10m to 6m.

Thanks!

@yurishkuro yurishkuro merged commit 7513b98 into jaegertracing:main May 3, 2024
38 of 39 checks passed
Pushkarm029 pushed a commit to Pushkarm029/jaeger that referenced this pull request May 4, 2024
…racing#5410)

## Which problem is this PR solving?

- Resolves jaegertracing#5350 


## Description of the changes
- Added the logic same in the docker-image CI to build linux/amd64
architecture only

## How was this change tested?
- Not yet

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test] Crossdock tests do not need to build Docker images for all architectures
2 participants