-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only build Docker images for Crossdock tests for linux/amd64 #5410
Conversation
Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5410 +/- ##
==========================================
+ Coverage 95.19% 95.21% +0.01%
==========================================
Files 346 346
Lines 16916 16916
==========================================
+ Hits 16104 16106 +2
+ Misses 610 609 -1
+ Partials 202 201 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@yurishkuro PTAL
|
Great, I am not seeing other arches in the logs, and the step run time went down from 10m to 6m. Thanks! |
…racing#5410) ## Which problem is this PR solving? - Resolves jaegertracing#5350 ## Description of the changes - Added the logic same in the docker-image CI to build linux/amd64 architecture only ## How was this change tested? - Not yet ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: Vamshi Maskuri <gwcchintu@gmail.com>
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test