Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Elasticsearch v5/v6 #5448

Merged
merged 2 commits into from
May 13, 2024

Conversation

FlamingSaint
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Removed support for Elasticsearch v5/v6 in mapping.go and mapping_test.go

How was this change tested?

Checklist

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from a team as a code owner May 13, 2024 10:19
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@yurishkuro yurishkuro added the changelog:breaking-change Change that is breaking public APIs or established behavior label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.48%. Comparing base (5757c56) to head (79a2f82).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5448      +/-   ##
==========================================
+ Coverage   95.47%   95.48%   +0.01%     
==========================================
  Files         331      331              
  Lines       16115    16113       -2     
==========================================
  Hits        15385    15385              
+ Misses        556      555       -1     
+ Partials      174      173       -1     
Flag Coverage Δ
badger_v1 8.07% <0.00%> (+<0.01%) ⬆️
badger_v2 1.94% <0.00%> (?)
cassandra-3.x-v1 16.48% <0.00%> (+<0.01%) ⬆️
cassandra-3.x-v2 1.86% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v1 16.48% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v2 1.86% <0.00%> (+<0.01%) ⬆️
elasticsearch-7.x 1.77% <0.00%> (-0.02%) ⬇️
elasticsearch-8.x 1.77% <0.00%> (-0.02%) ⬇️
grpc_v1 9.12% <0.00%> (+<0.01%) ⬆️
grpc_v2 7.49% <0.00%> (?)
kafka 9.81% <0.00%> (+<0.01%) ⬆️
opensearch-1.x 1.77% <0.00%> (+<0.01%) ⬆️
opensearch-2.x 1.78% <0.00%> (+0.01%) ⬆️
unittests 93.99% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit afd39dd into jaegertracing:main May 13, 2024
38 of 39 checks passed
@yurishkuro
Copy link
Member

Thanks!

@FlamingSaint FlamingSaint deleted the remove_esv5/6 branch May 24, 2024 23:41
pavolloffay added a commit to pavolloffay/jaeger that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:breaking-change Change that is breaking public APIs or established behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants